handle_action does not send HTTP response on failure, causing Alexa error

[Decapodian]

When handle_action in protocols.py fails (success=False), it only logs a warning and closes the transport without sending an HTTP response. This causes Alexa to timeout and report 'something went wrong' to the user.

The fix is to always send a valid SOAP response even on failure. Around line 187 in protocols.py, instead of only writing a response when success is True, always send the SOAP message.

This affects any plugin where on(), off(), or get_state() might fail or return unexpected values.

[n8henrie]

Thanks for the issue!

This behavior is somewhat intentional -- if the command fails, I would want Alexa to report that "something went wrong" (fail loudly).

If this is undesired behavior, I think you should be able to work around with use_fake_state.

I agree that waiting for the timeout is not a good user experience.

always send the SOAP message.

What would you recommend that the SOAP message contain in the case of a failure?