Data Storage Application writing corrupted files?

[mc-bane]

I have been using cFS to write files to my data acquisition system, and have been incorporating the DS app into my system which I used the eval-cert3 branch to make. I've updated the message and command APIs on the DS app, however I've come across a bit of a snag in getting readable files, as most (although not all) of my file data is corrupted. I'm able to get files to open, write, and close, but most of the data I write is corrupted and I'm not really sure why or how to fix it.

Here is the snippet where I write the header for a file. I am able to enter the first if-statement, as the Result from CFE_FS_WriteHeader is satisfied. And I am able to enter the second if-statement where I manually write the secondary header using OS_write.

(snip from ds/fsw/src/ds_file.c)

void DS_FileWriteHeader(int32 FileIndex)
{
    DS_DestFileEntry_t *DestFile = &DS_AppData.DestFileTblPtr->File[FileIndex];
    DS_AppFileStatus_t *FileStatus = &DS_AppData.FileStatus[FileIndex];
    CFE_FS_Header_t CFE_FS_Header;
    DS_FileHeader_t DS_FileHeader;
    int32 Result = CFE_SUCCESS;


    /*
    ** Initialize selected parts of the cFE file header...
    */
	CFE_PSP_MemSet(&CFE_FS_Header, 0, sizeof(CFE_FS_Header_t));
    CFE_FS_Header.SubType = DS_FILE_HDR_SUBTYPE;
    strcpy(CFE_FS_Header.Description, DS_FILE_HDR_DESCRIPTION);
  
    /*
    ** Let cFE finish the init and write the primary header...
    */
    //OS_printf("handlewriteheader: %d \n", FileStatus->FileHandle);
    Result = CFE_FS_WriteHeader(FileStatus->FileHandle, &CFE_FS_Header);
   

    if (Result == sizeof(CFE_FS_Header_t))
    {
        /*
        ** Success - update file size and data rate counters...
        */
        DS_AppData.FileWriteCounter++;

        FileStatus->FileSize   += sizeof(CFE_FS_Header_t);
        FileStatus->FileGrowth += sizeof(CFE_FS_Header_t);

        /*
        ** Initialize the DS file header...
        */
        CFE_PSP_MemSet(&DS_FileHeader, 0, sizeof(DS_FileHeader_t));
        DS_FileHeader.FileTableIndex = FileIndex;
        DS_FileHeader.FileNameType = DestFile->FileNameType;
        strcpy(DS_FileHeader.FileName, FileStatus->FileName);

        /*
        ** Manually write the secondary header...
        */
       //OS_printf("handlewritesecondaryheader: %d \n", FileStatus->FileHandle);
       Result = OS_write(FileStatus->FileHandle, &DS_FileHeader, sizeof(DS_FileHeader_t));

        if (Result == sizeof(DS_FileHeader_t))
        {
            /*
            ** Success - update file size and data rate counters...
            */
            DS_AppData.FileWriteCounter++;

            FileStatus->FileSize   += sizeof(DS_FileHeader_t);
            FileStatus->FileGrowth += sizeof(DS_FileHeader_t);
        }
        else
        {
            /*
            ** Error - send event, close file and disable destination...
            */
            DS_FileWriteError(FileIndex, sizeof(DS_FileHeader_t), Result);
        }
    }
    else
    {
        /*
        ** Error - send event, close file and disable destination...
        */
        DS_FileWriteError(FileIndex, sizeof(CFE_FS_Header_t), Result);
    }

    return;

} /* End of DS_FileWriteHeader() */

and here is my output file. My actual data is being written by a different function, but I suspect the issue is related since the headers are also partially corrupted.

[jphickey]

Why do you think the data is corrupted? Note these are binary files, not text. You'd have to open them in a hex editor to see the contents. ("hexedit" is a convenient command line tool I use often)

[mc-bane]

thanks! I thought it might be something silly I was doing.