feat: enhance parser error messages with precise file, line, and column numbers and structured agent outputs

Author: nathfavour

cli/ship/main.go

@@ -9,6 +9,8 @@ import (
 	"os"
 	"os/exec"
 	"path/filepath"
+	"strconv"
+	"strings"
 
 	"github.com/nathfavour/ship/compiler/emitter/elf"
 	"github.com/nathfavour/ship/compiler/ir"
@@ -258,12 +260,44 @@ func fatalError(msg string, agent bool) {
 
 func reportAgentErrors(phase string, errors []string) {
 	for _, msg := range errors {
-		out, _ := json.Marshal(map[string]interface{}{
-			"status": "error",
-			"phase":  phase,
-			"error":  msg,
-		})
-		fmt.Fprintln(os.Stderr, string(out))
+		file := ""
+		line := 0
+		col := 0
+		errMsg := msg
+
+		parts := strings.SplitN(msg, ":", 4)
+		if len(parts) >= 4 {
+			l, err1 := strconv.Atoi(parts[1])
+			c, err2 := strconv.Atoi(parts[2])
+			if err1 == nil && err2 == nil {
+				file = parts[0]
+				line = l
+				col = c
+				errMsg = strings.TrimSpace(parts[3])
+			}
+		}
+
+		if line > 0 {
+			out, _ := json.Marshal(map[string]interface{}{
+				"status": "error",
+				"phase":  phase,
+				"error":  errMsg,
+				"target": map[string]interface{}{
+					"file":     file,
+					"function": "",
+					"line":     line,
+					"char":     col,
+				},
+			})
+			fmt.Fprintln(os.Stderr, string(out))
+		} else {
+			out, _ := json.Marshal(map[string]interface{}{
+				"status": "error",
+				"phase":  phase,
+				"error":  msg,
+			})
+			fmt.Fprintln(os.Stderr, string(out))
+		}
 	}
 }
 

compiler/parser/parser.go

@@ -338,7 +338,7 @@ func (p *Parser) parseIntegerLiteral() ast.Expression {
 
 	value, err := strconv.ParseInt(p.curToken.Literal, 0, 64)
 	if err != nil {
-		msg := fmt.Sprintf("could not parse %q as integer", p.curToken.Literal)
+		msg := fmt.Sprintf("%s:%d:%d: could not parse %q as integer", p.curToken.File, p.curToken.Line, p.curToken.Col, p.curToken.Literal)
 		p.errors = append(p.errors, msg)
 		return nil
 	}
@@ -492,8 +492,8 @@ func (p *Parser) expectPeek(t token.Type) bool {
 }
 
 func (p *Parser) peekError(t token.Type) {
-	msg := fmt.Sprintf("expected next token to be %s, got %s instead",
-		t, p.peekToken.Type)
+	msg := fmt.Sprintf("%s:%d:%d: expected next token to be %s, got %s instead",
+		p.peekToken.File, p.peekToken.Line, p.peekToken.Col, t, p.peekToken.Type)
 	p.errors = append(p.errors, msg)
 }
 
@@ -506,7 +506,8 @@ func (p *Parser) registerInfix(tokenType token.Type, fn infixParseFn) {
 }
 
 func (p *Parser) noPrefixParseFnError(t token.Type) {
-	msg := fmt.Sprintf("no prefix parse function for %s found", t)
+	msg := fmt.Sprintf("%s:%d:%d: no prefix parse function for %s found",
+		p.curToken.File, p.curToken.Line, p.curToken.Col, t)
 	p.errors = append(p.errors, msg)
 }