Skip to content

Commit 64e670e

Browse files
pi-nathannathonius
authored andcommitted
fix: correct setIcon signature
1 parent eabc5b1 commit 64e670e

File tree

2 files changed

+11
-9
lines changed

2 files changed

+11
-9
lines changed

src/modal/card-create-modal.ts

+5-4
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
import { App, Modal, setIcon } from 'obsidian';
2-
import { Subject } from 'rxjs';
3-
import { map } from 'rxjs/operators';
4-
import { Accordion } from '../accordion/accordion';
52
import { CardPosition, PluginError, TrelloBoard, TrelloCard, TrelloLabel, TrelloList } from 'src/interfaces';
3+
4+
import { Accordion } from '../accordion/accordion';
5+
import { Subject } from 'rxjs';
66
import { TrelloPlugin } from '../plugin';
7+
import { map } from 'rxjs/operators';
78

89
/**
910
* Create a new card and update createdCard
@@ -137,7 +138,7 @@ export class CardCreateModal extends Modal {
137138
check.empty();
138139
delete this.selectedLabels[label.id];
139140
} else {
140-
setIcon(check, 'checkbox-glyph', 20);
141+
setIcon(check, 'checkbox-glyph');
141142
this.selectedLabels[label.id] = label;
142143
}
143144
});

src/view/view.ts

+6-5
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1-
import { ItemView, MarkdownRenderer, Notice, setIcon, WorkspaceLeaf } from 'obsidian';
2-
import { combineLatest, Subject } from 'rxjs';
3-
import { takeUntil, tap } from 'rxjs/operators';
41
import { CUSTOM_ICONS, TRELLO_ERRORS, TRELLO_VIEW_TYPE } from '../constants';
2+
import { ItemView, MarkdownRenderer, Notice, WorkspaceLeaf, setIcon } from 'obsidian';
53
import {
64
PluginError,
75
PluginUISettings,
@@ -12,9 +10,12 @@ import {
1210
TrelloChecklist,
1311
TrelloList
1412
} from '../interfaces';
13+
import { Subject, combineLatest } from 'rxjs';
14+
import { takeUntil, tap } from 'rxjs/operators';
15+
16+
import { Accordion } from '../accordion/accordion';
1517
import { TrelloPlugin } from '../plugin';
1618
import { TrelloViewManager } from './view-manager';
17-
import { Accordion } from '../accordion/accordion';
1819

1920
export class TrelloView extends ItemView {
2021
private readonly destroy = new Subject<void>();
@@ -216,7 +217,7 @@ export class TrelloView extends ItemView {
216217
const cardLink = cardName.createEl('a', {
217218
attr: { href: card.url, 'aria-label': 'View on Trello' }
218219
});
219-
setIcon(cardLink, 'navigate-glyph', 24);
220+
setIcon(cardLink, 'navigate-glyph');
220221
}
221222

222223
/**

0 commit comments

Comments
 (0)