Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enableIOSDTCoreText is not a function #19

Open
fpaaske opened this issue Aug 2, 2023 · 4 comments
Open

enableIOSDTCoreText is not a function #19

fpaaske opened this issue Aug 2, 2023 · 4 comments

Comments

@fpaaske
Copy link

fpaaske commented Aug 2, 2023

I'd just let you know that we ran into this issue recently. After some debugging it seems like it's probably due to this commit from https://github.com/nativescript-community/text

This bug came to us via a patch release of ui-label, but I think this qualifies as a breaking change (in the text-repo)? That would prevent it from sneaking in unnoticed, I think 😊

Anyway, I see that the feature was removed, so we've adapted the code.
Perhaps you could update the documentation?

Thanks for an otherwise excellent plugin! ❤️

@farfromrefug
Copy link
Member

@fpaaske sorry about this. I can bring in back if you want but dtcoretext hasn't been updated in a very long time. otherwise I LL update the doc.
thanks

@fpaaske
Copy link
Author

fpaaske commented Aug 2, 2023

No worries, and thanks for the quick response! I don't think we need DTCoreText. I don't even know what it's for, except is was recommend for performance some years back.

The plugin seems to work the same without it 👍

@farfromrefug
Copy link
Member

ok so you understand dtcoretext was there to parse XML string into NSattributedstring. but now in latest iOS versions iOS do it pretty well. in the beginning dtcoretext was faster but it is not maintained anymore and I dont even think it is faster now. will update the doc

@fpaaske
Copy link
Author

fpaaske commented Aug 3, 2023

That's good to know. I guess the fewer deps the better. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants