-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enableIOSDTCoreText is not a function #19
Comments
@fpaaske sorry about this. I can bring in back if you want but dtcoretext hasn't been updated in a very long time. otherwise I LL update the doc. |
No worries, and thanks for the quick response! I don't think we need DTCoreText. I don't even know what it's for, except is was recommend for performance some years back. The plugin seems to work the same without it 👍 |
ok so you understand dtcoretext was there to parse XML string into NSattributedstring. but now in latest iOS versions iOS do it pretty well. in the beginning dtcoretext was faster but it is not maintained anymore and I dont even think it is faster now. will update the doc |
That's good to know. I guess the fewer deps the better. Thanks again! |
I'd just let you know that we ran into this issue recently. After some debugging it seems like it's probably due to this commit from https://github.com/nativescript-community/text
This bug came to us via a patch release of ui-label, but I think this qualifies as a breaking change (in the text-repo)? That would prevent it from sneaking in unnoticed, I think 😊
Anyway, I see that the feature was removed, so we've adapted the code.
Perhaps you could update the documentation?
Thanks for an otherwise excellent plugin! ❤️
The text was updated successfully, but these errors were encountered: