Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardware API andpoint implementation is incompatible with nautobot-ansible plugin module. #290

Merged
merged 11 commits into from
Aug 9, 2024

Conversation

pszulczewski
Copy link
Contributor

See the issue in nautobot-ansible for more information.
nautobot/nautobot-ansible#306
If this PR is accepted it would need a new major release.

@progala
Copy link
Contributor

progala commented Feb 22, 2024

Thanks @pszulczewski . With it being a breaking change we'll target this to be merged into the next3.0 release.

@progala progala changed the base branch from develop to next3.0 February 22, 2024 09:55
@progala progala added this to the Release v3.0 milestone Feb 22, 2024
@progala progala changed the base branch from next3.0-old to next3.0 July 1, 2024 08:31
@progala
Copy link
Contributor

progala commented Jul 12, 2024

@pszulczewski Can you give an example of an API call that works now and will stop working once this is merged? We'll need to properly document it so that users are aware of changes they need to make.

@pszulczewski
Copy link
Contributor Author

@progala field names in filtered API calls will change like this:

current filtered API call:
'https://<host>/api/plugins/nautobot-device-lifecycle-mgmt/hardware/?device_type=Catalyst+6509-E'
will change to:
'https://<host>/api/plugins/nautobot-device-lifecycle-mgmt/hardware/?device_type_model=Catalyst+6509-E'

device_type --> device_type_model

current filtered API call:
'https://<host>/api/plugins/nautobot-device-lifecycle-mgmt/hardware/?device_type_id=4bf23e23-4eb1-4fae-961c-edd6f8cbaaf1'
will change to:
'https://<host>/api/plugins/nautobot-device-lifecycle-mgmt/hardware/?device_type=4bf23e23-4eb1-4fae-961c-edd6f8cbaaf1'

device_type_id --> device_type

@progala
Copy link
Contributor

progala commented Jul 18, 2024

@pszulczewski Thanks! That makes sense to me. Could you just add a change fragment and I'll get it merged.

@progala progala force-pushed the nautobot-ansible_issue_306 branch from efd9662 to ee6b731 Compare August 7, 2024 09:42
@progala progala merged commit 02bf22d into next3.0 Aug 9, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plugin module fails to create nautobot-device-lifecycle-mgmt hardware entries
2 participants