Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR 822 Introduces failures in testing due to DynamicGroupTypeChoices not being availble until 2.3 #880

Open
jeffkala opened this issue Feb 6, 2025 · 1 comment

Comments

@jeffkala
Copy link
Contributor

jeffkala commented Feb 6, 2025

Environment

  • Python version: 3.11
  • Nautobot version: 2.3
  • nautobot-golden-config version: develop branch

Expected Behavior

Testing should pass

Observed Behavior

Pylint is failing

Steps to Reproduce

  1. Run test against develop branch
    spec.loader.exec_module(module)
  File "/source/nautobot_golden_config/urls.py", line 8, in <module>
    from nautobot_golden_config import views
  File "/source/nautobot_golden_config/views.py", line 27, in <module>
    from nautobot_golden_config.api import serializers
  File "/source/nautobot_golden_config/api/serializers.py", line 14, in <module>
    from nautobot_golden_config.utilities.config_postprocessing import get_config_postprocessing
  File "/source/nautobot_golden_config/utilities/config_postprocessing.py", line 22, in <module>
    from nautobot_golden_config.utilities.helper import get_device_to_settings_map
  File "/source/nautobot_golden_config/utilities/helper.py", line 19, in <module>
    from nautobot.extras.choices import DynamicGroupTypeChoices
ImportError: cannot import name 'DynamicGroupTypeChoices' from 'nautobot.extras.choices' (/usr/local/lib/python3.11/site-packages/nautobot/extras/choices.py)
Running docker compose command "ps --services --filter status=running"
Running docker compose command "run --rm --entrypoint='pylint --verbose --init-hook "import nautobot; nautobot.setup()" --rcfile pyproject.toml --load-plugins=pylint_django.checkers.migrations --disable=all --enable=fatal,new-db-field-with-default,missing-backwards-migration-callable nautobot_golden_config.migrations' nautobot"
25l[+] Creating 2/0

Fix

Make the min version 2.3 for the app, or yank that PR.

@jeffkala
Copy link
Contributor Author

jeffkala commented Feb 6, 2025

Already will be fixed by #866

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant