Skip to content

Commit 75dfa23

Browse files
MUFFANUJjbouderclaude
authored
Migrate frontend UI primitives to Nebari design registry (#460)
* Migrate frontend UI primitives to Nebari design registry * Update Registries and PublishDialog tests for the Nebari Select migration The merge from main brought in tests written against the old native select and Radix dialog autofocus. The Nebari/Base UI Select trigger is a combobox button, so assert on its visible text instead of .value, and drop the focus wait the Base UI dialog no longer satisfies. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * apply suggestion * remove dark and change inactive/active pill/toggle * fix acc rules * apply suggestions --------- Co-authored-by: Johnny Bouder <jbouder@openteams.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
1 parent f0bbbfb commit 75dfa23

59 files changed

Lines changed: 3998 additions & 2850 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

frontend/biome.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"$schema": "https://biomejs.dev/schemas/2.4.16/schema.json",
2+
"$schema": "https://biomejs.dev/schemas/2.5.2/schema.json",
33

44
"vcs": {
55
"enabled": true,
@@ -29,7 +29,7 @@
2929
"linter": {
3030
"enabled": true,
3131
"rules": {
32-
"recommended": true,
32+
"preset": "recommended",
3333

3434
"correctness": {
3535
"noUndeclaredVariables": "error"

frontend/components.json

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
{
2+
"$schema": "https://ui.shadcn.com/schema.json",
3+
"style": "new-york",
4+
"rsc": false,
5+
"tsx": true,
6+
"tailwind": {
7+
"config": "",
8+
"css": "src/index.css",
9+
"baseColor": "neutral",
10+
"cssVariables": true,
11+
"prefix": ""
12+
},
13+
"aliases": {
14+
"components": "@/components",
15+
"utils": "@/lib/utils",
16+
"ui": "@/components/ui",
17+
"lib": "@/lib",
18+
"hooks": "@/hooks"
19+
},
20+
"iconLibrary": "lucide",
21+
"registries": {
22+
"@nebari": "https://nebari-dev.github.io/nebari-design/r/{name}.json"
23+
}
24+
}

frontend/e2e/workspaces.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ python = ">=3.11"
3535
await expect(
3636
page.getByRole('heading', { name: 'e2e-created-workspace' }),
3737
).toBeVisible();
38-
await page.getByRole('button', { name: 'Jobs' }).click();
38+
await page.getByRole('tab', { name: 'Jobs' }).click();
3939
await expect(page.getByRole('heading', { name: 'Jobs' })).toBeVisible();
4040
await expect(page.getByText('Workspace created successfully')).toBeVisible();
4141
await expectNoCriticalOrSeriousA11yViolations(page);

0 commit comments

Comments
 (0)