Wrong typing for AsyncRelationshipDefinition __init__ param #854

Author: mariusconjeaud

.sonarcloud.properties

@@ -1,3 +1,3 @@
 sonar.sources = neomodel/
 sonar.tests = test/
-sonar.python.version = 3.7, 3.8, 3.9, 3.10, 3.11
+sonar.python.version = 3.9, 3.10, 3.11, 3.12, 3.13

neomodel/async_/relationship_manager.py

@@ -433,7 +433,7 @@ def __init__(
         cls_name: str,
         direction: int,
         manager: type[AsyncRelationshipManager] = AsyncRelationshipManager,
-        model: Optional[AsyncStructuredRel] = None,
+        model: Optional[type[AsyncStructuredRel]] = None,
     ) -> None:
         self._validate_class(cls_name, model)
 
@@ -486,7 +486,7 @@ def __init__(
                 adb._NODE_CLASS_REGISTRY[label_set] = model
 
     def _validate_class(
-        self, cls_name: str, model: Optional[AsyncStructuredRel] = None
+        self, cls_name: str, model: Optional[type[AsyncStructuredRel]] = None
     ) -> None:
         if not isinstance(cls_name, (str, object)):
             raise ValueError("Expected class name or class got " + repr(cls_name))
@@ -552,7 +552,7 @@ def __init__(
         cls_name: str,
         relation_type: str,
         cardinality: type[AsyncRelationshipManager] = AsyncZeroOrMore,
-        model: Optional[AsyncStructuredRel] = None,
+        model: Optional[type[AsyncStructuredRel]] = None,
     ) -> None:
         super().__init__(
             relation_type, cls_name, OUTGOING, manager=cardinality, model=model
@@ -565,7 +565,7 @@ def __init__(
         cls_name: str,
         relation_type: str,
         cardinality: type[AsyncRelationshipManager] = AsyncZeroOrMore,
-        model: Optional[AsyncStructuredRel] = None,
+        model: Optional[type[AsyncStructuredRel]] = None,
     ) -> None:
         super().__init__(
             relation_type, cls_name, INCOMING, manager=cardinality, model=model
@@ -578,7 +578,7 @@ def __init__(
         cls_name: str,
         relation_type: str,
         cardinality: type[AsyncRelationshipManager] = AsyncZeroOrMore,
-        model: Optional[AsyncStructuredRel] = None,
+        model: Optional[type[AsyncStructuredRel]] = None,
     ) -> None:
         super().__init__(
             relation_type, cls_name, EITHER, manager=cardinality, model=model

neomodel/sync_/relationship_manager.py

@@ -410,7 +410,7 @@ def __init__(
         cls_name: str,
         direction: int,
         manager: type[RelationshipManager] = RelationshipManager,
-        model: Optional[StructuredRel] = None,
+        model: Optional[type[StructuredRel]] = None,
     ) -> None:
         self._validate_class(cls_name, model)
 
@@ -463,7 +463,7 @@ def __init__(
                 db._NODE_CLASS_REGISTRY[label_set] = model
 
     def _validate_class(
-        self, cls_name: str, model: Optional[StructuredRel] = None
+        self, cls_name: str, model: Optional[type[StructuredRel]] = None
     ) -> None:
         if not isinstance(cls_name, (str, object)):
             raise ValueError("Expected class name or class got " + repr(cls_name))
@@ -527,7 +527,7 @@ def __init__(
         cls_name: str,
         relation_type: str,
         cardinality: type[RelationshipManager] = ZeroOrMore,
-        model: Optional[StructuredRel] = None,
+        model: Optional[type[StructuredRel]] = None,
     ) -> None:
         super().__init__(
             relation_type, cls_name, OUTGOING, manager=cardinality, model=model
@@ -540,7 +540,7 @@ def __init__(
         cls_name: str,
         relation_type: str,
         cardinality: type[RelationshipManager] = ZeroOrMore,
-        model: Optional[StructuredRel] = None,
+        model: Optional[type[StructuredRel]] = None,
     ) -> None:
         super().__init__(
             relation_type, cls_name, INCOMING, manager=cardinality, model=model
@@ -553,7 +553,7 @@ def __init__(
         cls_name: str,
         relation_type: str,
         cardinality: type[RelationshipManager] = ZeroOrMore,
-        model: Optional[StructuredRel] = None,
+        model: Optional[type[StructuredRel]] = None,
     ) -> None:
         super().__init__(
             relation_type, cls_name, EITHER, manager=cardinality, model=model