Merge pull request #6862 from neo4j/remove-unused-exports

Remove unused exports and dependencies

Author: angrykoala

packages/graphql/knip.json

@@ -0,0 +1,18 @@
+{
+    "$schema": "https://unpkg.com/knip@5/schema.json",
+    "ignoreExportsUsedInFile": {
+        "interface": false,
+        "type": false
+    },
+    "tags": ["-lintignore"],
+    "ignoreFiles": [
+        "tests/performance/**",
+        "tests/utils/**",
+        "tests/integration/teardown.ts",
+        "tests/e2e/**",
+        "jest-*-setup.js"
+    ],
+    "ignoreBinaries": [],
+    "ignoreDependencies": ["jest", "rimraf", "ts-node"],
+    "treatConfigHintsAsErrors": true
+}

packages/graphql/package.json

@@ -41,13 +41,13 @@
         "test:schema": "jest tests/schema -c jest.minimal.config.js",
         "test:tck": "jest tests/tck -c jest.minimal.config.js",
         "test:unit": "jest src --coverage=true -c jest.minimal.config.js",
-        "test": "jest"
+        "test": "jest",
+        "knip": "knip"
     },
     "author": "Neo4j Inc.",
     "devDependencies": {
         "@apollo/gateway": "2.12.1",
         "@apollo/server": "5.2.0",
-        "@types/deep-equal": "1.0.4",
         "@types/is-uuid": "1.0.2",
         "@types/jest": "30.0.0",
         "@types/jsonwebtoken": "9.0.10",
@@ -65,11 +65,11 @@
         "jest-extended": "7.0.0",
         "jsonwebtoken": "9.0.2",
         "jwks-rsa": "3.2.0",
+        "knip": "5.70.2",
         "koa": "3.1.1",
         "koa-jwt": "4.0.4",
         "koa-router": "14.0.0",
         "mock-jwks": "3.3.5",
-        "nock": "14.0.10",
         "randomstring": "1.3.1",
         "rimraf": "6.1.2",
         "supertest": "7.1.4",

packages/graphql/src/classes/subscription/cdc/cdc-types.ts

@@ -19,6 +19,22 @@
 
 import type { DateTime } from "neo4j-driver";
 
+export type CDCNodeEvent = {
+    elementId: string;
+    eventType: "n";
+    state: {
+        before?: CDCEventState;
+        after?: CDCEventState;
+    };
+    operation: CDCOperation;
+    labels: string[];
+};
+export type CDCQueryResponse = {
+    id: string;
+    event: CDCEvent;
+    metadata: CDCMetadata;
+};
+
 type CDCEventState = {
     properties: Record<string, unknown>;
     labels: string[];
@@ -34,7 +50,7 @@ type CDCRelationshipNode = {
 
 type CDCOperation = "c" | "d" | "u";
 
-export type CDCRelationshipEvent = {
+type CDCRelationshipEvent = {
     elementId: string;
     eventType: "r";
     start: CDCRelationshipNode;
@@ -47,26 +63,9 @@ export type CDCRelationshipEvent = {
     type: string;
 };
 
-export type CDCNodeEvent = {
-    elementId: string;
-    eventType: "n";
-    state: {
-        before?: CDCEventState;
-        after?: CDCEventState;
-    };
-    operation: CDCOperation;
-    labels: string[];
-};
-
-export type CDCMetadata = {
+type CDCMetadata = {
     txStartTime: DateTime;
     // Other metadata is ignored here
 };
 
-export type CDCEvent = CDCNodeEvent | CDCRelationshipEvent;
-
-export type CDCQueryResponse = {
-    id: string;
-    event: CDCEvent;
-    metadata: CDCMetadata;
-};
+type CDCEvent = CDCNodeEvent | CDCRelationshipEvent;

packages/graphql/src/classes/utils/asserts-indexes-and-constraints.ts

@@ -26,10 +26,6 @@ import type { Neo4jGraphQLSessionConfig } from "../Executor";
 
 const debug = Debug(DEBUG_EXECUTE);
 
-export interface AssertIndexesAndConstraintsOptions {
-    create?: boolean;
-}
-
 export async function assertIndexesAndConstraints({
     driver,
     sessionConfig,

packages/graphql/src/constants.ts

@@ -29,7 +29,6 @@ export const AUTHORIZATION_UNAUTHENTICATED = "Unauthenticated";
 export const DEBUG_ALL = `${DEBUG_PREFIX}:*`;
 export const DEBUG_AUTH = `${DEBUG_PREFIX}:auth`;
 export const DEBUG_EXECUTE = `${DEBUG_PREFIX}:execution`;
-export const DEBUG_GENERATE = `${DEBUG_PREFIX}:generate`;
 export const DEBUG_GRAPHQL = `${DEBUG_PREFIX}:graphql`;
 export const DEBUG_TRANSLATE = `${DEBUG_PREFIX}:translate`;
 
@@ -87,9 +86,6 @@ export enum RelationshipNestedOperationsOption {
     DISCONNECT = "DISCONNECT",
 }
 
-export const META_CYPHER_VARIABLE = "meta";
-export const META_OLD_PROPS_CYPHER_VARIABLE = "oldProps";
-
 export const DBMS_COMPONENTS_QUERY =
     "CALL dbms.components() YIELD versions, edition UNWIND versions AS version RETURN version, edition";
 

packages/graphql/src/graphql/directives/declare-relationship.ts

@@ -21,7 +21,7 @@ import { DirectiveLocation, GraphQLBoolean, GraphQLDirective, GraphQLList, Graph
 import { RelationshipNestedOperationsOption } from "../../constants";
 import { RelationshipNestedOperationsEnum } from "./arguments/enums/RelationshipNestedOperations";
 
-export const defaultNestedOperations = [
+const defaultNestedOperations = [
     RelationshipNestedOperationsOption.CREATE,
     RelationshipNestedOperationsOption.UPDATE,
     RelationshipNestedOperationsOption.DELETE,

packages/graphql/src/graphql/directives/relationship.ts

@@ -30,7 +30,7 @@ import { RelationshipDirectionEnum } from "./arguments/enums/RelationshipDirecti
 import { RelationshipNestedOperationsEnum } from "./arguments/enums/RelationshipNestedOperations";
 import { RelationshipQueryDirectionEnum } from "./arguments/enums/RelationshipQueryDirection";
 
-export const defaultNestedOperations = [
+const defaultNestedOperations = [
     RelationshipNestedOperationsOption.CREATE,
     RelationshipNestedOperationsOption.UPDATE,
     RelationshipNestedOperationsOption.DELETE,

packages/graphql/src/graphql/directives/vector.ts

@@ -27,7 +27,7 @@ import {
     GraphQLString,
 } from "graphql";
 
-export const vectorProviderNames = {
+const vectorProviderNames = {
     VERTEX_AI: "VertexAI",
     OPEN_AI: "OpenAI",
     AZURE_OPEN_AI: "AzureOpenAI",

packages/graphql/src/graphql/scalars/Duration.ts

@@ -36,14 +36,14 @@ const DURATION_REGEX_NO_DELIMITERS =
 
 // Normalized components per https://neo4j.com/docs/cypher-manual/current/syntax/operators/#cypher-ordering
 export const MONTHS_PER_YEAR = 12;
-export const DAYS_PER_YEAR = 365.2425;
-export const DAYS_PER_MONTH = DAYS_PER_YEAR / MONTHS_PER_YEAR;
+const DAYS_PER_YEAR = 365.2425;
+const DAYS_PER_MONTH = DAYS_PER_YEAR / MONTHS_PER_YEAR;
 export const DAYS_PER_WEEK = 7;
-export const HOURS_PER_DAY = 24;
-export const MINUTES_PER_HOUR = 60;
+const HOURS_PER_DAY = 24;
+const MINUTES_PER_HOUR = 60;
 export const SECONDS_PER_MINUTE = 60;
 export const SECONDS_PER_HOUR = SECONDS_PER_MINUTE * MINUTES_PER_HOUR;
-export const NANOSECONDS_PER_SECOND = 1000000000;
+const NANOSECONDS_PER_SECOND = 1000000000;
 
 export const parseDuration = (
     value: string

packages/graphql/src/graphql/scalars/LocalTime.ts

@@ -21,7 +21,7 @@ import type { ValueNode } from "graphql";
 import { GraphQLError, GraphQLScalarType, Kind } from "graphql";
 import neo4j, { isLocalTime } from "neo4j-driver";
 
-export const LOCAL_TIME_REGEX =
+const LOCAL_TIME_REGEX =
     /^(?<hour>[01]\d|2[0-3]):(?<minute>[0-5]\d):(?<second>[0-5]\d)(\.(?<fraction>\d{1}(?:\d{0,8})))?$/;
 
 type LocalTimeMatchGroups = {