Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9.0 Ensure that document-node is redirected to the nearest parent on workspace change #3815

Open
mhsdesign opened this issue Jun 25, 2024 · 0 comments

Comments

@mhsdesign
Copy link
Member

The pr #3734 fixed the behaviour in Neos 8.3 but the code was not upmergeable.

The current 9.0 implementation throws many phpstan errors and is probably doomed in some way and must be refactored.

// If current document node doesn't exist in the base workspace,
// traverse its parents to find the one that exists
// todo ensure that https://github.com/neos/neos-ui/pull/3734 doesnt need to be refixed in Neos 9.0
$redirectNode = $documentNode;
while (true) {

Both scenariao should pass at the end.

Scenario 1:

create workspace
create new subpage in workspace and publish and highlight it
change workspace to live again

Scenario 2:

create workspace
create new subpage in workspace
create new subsubpage in workspace
publish and highlight the new subsubpage
change workspace to live again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant