refactoring base class

Author: JensRavens

.gitignore

@@ -11,3 +11,5 @@
 
 # rspec failure tracking
 .rspec_status
+/.byebug_history
+/spec/lib/generators/test/generator_spec/test_destination

lib/generators/pixelpress/printer/printer_generator.rb

@@ -31,6 +31,8 @@ def file_name # :doc:
 
       def engine_mounted?
         routes = Rails.root.join('config/routes.rb')
+        puts "HELLO!"
+        puts routes
         routes.exist? && routes.read.include?('Pixelpress::Engine')
       end
     end

lib/pixelpress.rb

@@ -1,5 +1,6 @@
 require 'pixelpress/version'
 require 'pixelpress/base'
+require 'pixelpress/document'
 require 'pixelpress/engine' if defined? Rails
 require 'pixelpress/preview' if defined? Rails
 

lib/pixelpress/base.rb

@@ -1,53 +1,12 @@
 require 'action_controller'
-require 'weasyprint'
+require_relative 'renderers/weasyprint_renderer'
+require_relative 'renderers/test_renderer'
+require_relative 'instance_invocation'
+require_relative 'rendering'
 
 module Pixelpress
   class Base < ActionController::Base
-    def html
-      render(template) unless @html
-      @html
-    end
-
-    def pdf
-      stream = StringIO.new pdf_data
-      stream.singleton_class.class_eval { attr_accessor :original_filename, :content_type }
-      stream.original_filename = try(:file_name) || 'document.pdf'
-      stream.content_type = 'application/pdf'
-      stream
-    end
-
-    class << self
-      def method_missing(m, *args, &block)
-        return super unless respond_to_missing?(m)
-        instance = new
-        instance.send(m, *args)
-        instance.instance_variable_set :@template_name, m.to_s
-        instance
-      end
-
-      def respond_to_missing?(m, include_private = false)
-        return true if new.methods.include?(m)
-        super(m, include_private)
-      end
-    end
-
-    protected
-
-    attr_accessor :template
-
-    def template
-      ['printers', self.class.to_s.underscore.sub('_printer', ''), @template_name].join('/')
-    end
-
-    private
-
-    def pdf_data
-      return '%PDF-1.5' if ENV['RAILS_ENV'] == 'test'
-      WeasyPrint.new(html).to_pdf
-    end
-
-    def render(template = caller_locations(1, 1)[0].label)
-      @html = render_to_string(template)
-    end
+    extend InstanceInvocation
+    include Rendering
   end
 end

lib/pixelpress/document.rb

@@ -0,0 +1,26 @@
+require_relative 'fake_file'
+
+module Pixelpress
+  class Document
+    attr_reader :html
+    attr_reader :file_name
+
+    def initialize(html, renderer, options = {})
+      @html = html
+      @renderer = renderer
+      @file_name = options[:file_name]
+    end
+
+    def pdf
+      FakeFile.new pdf_data, original_filename: file_name
+    end
+
+    private
+
+    attr_accessor :renderer
+
+    def pdf_data
+      @pdf_data ||= renderer.render(html)
+    end
+  end
+end

lib/pixelpress/fake_file.rb

@@ -0,0 +1,19 @@
+module Pixelpress
+  class FakeFile < StringIO
+    attr_accessor :original_filename, :content_type
+
+    def initialize(data, options = {})
+      @original_filename = options[:original_filename]
+      @content_type = options[:content_type]
+      super data
+    end
+
+    def original_filename
+      @original_filename || "document.pdf"
+    end
+
+    def content_type
+      @content_type || "application/pdf"
+    end
+  end
+end

lib/pixelpress/instance_invocation.rb

@@ -0,0 +1,15 @@
+module Pixelpress
+  module InstanceInvocation
+    def method_missing(m, *args, &block)
+      return super unless respond_to_missing?(m)
+      instance = new
+      instance.instance_variable_set :@template_name, m.to_s
+      instance.send(m, *args)
+      instance.document
+    end
+
+    def respond_to_missing?(m, include_private = false)
+      return true if new.methods.include?(m)
+    end
+  end
+end

lib/pixelpress/renderers/test_renderer.rb

@@ -0,0 +1,5 @@
+class Pixelpress::TestRenderer
+  def render(html)
+     '%PDF-1.5'
+  end
+end

lib/pixelpress/renderers/weasyprint_renderer.rb

@@ -0,0 +1,7 @@
+require 'weasyprint'
+
+class Pixelpress::WeasyPrintRenderer
+  def render(html)
+    WeasyPrint.new(html).to_pdf
+  end
+end

lib/pixelpress/rendering.rb

@@ -0,0 +1,28 @@
+module Pixelpress
+  module Rendering
+    module ClassMethods
+      attr_writer :default_renderer
+      def default_renderer
+        @default_renderer ||= WeasyPrintRenderer.new
+      end
+    end
+
+    def self.included(base)
+      base.extend(ClassMethods)
+    end
+
+    def document
+      @document ||= Document.new render_to_string(template), renderer, file_name: try(:file_name)
+    end
+
+    protected
+
+    def renderer
+      @renderer || self.class.default_renderer
+    end
+
+    def template
+      ['printers', controller_path.sub('_printer', ''), @template_name].join('/')
+    end
+  end
+end

spec/lib/generators/test/generator_spec/printer_generator_spec.rb

@@ -1,13 +1,16 @@
 require 'spec_helper'
 
 RSpec.describe Pixelpress::Generators::PrinterGenerator do
-  destination File.expand_path('../test_destination', __FILE__)
+  path = File.expand_path('../test_destination', __FILE__)
+  destination path
   arguments %w(Auth::UserPrinter user_data)
 
   before(:each) do
     prepare_destination
-    # File.write("../test_destination/config/routes.rb", 'mount Pixelpress::Engine => "rails" if Rails.env.development?')
-    allow(Rails).to receive(:root).and_return Pathname.new('../test_destination/app/')
+    allow(Rails).to receive(:root).and_return Pathname.new(path)
+    puts "#{path}/config"
+    FileUtils.mkdir_p "#{path}/config"
+    File.write("#{path}/config/routes.rb", 'mount Pixelpress::Engine => "rails" if Rails.env.development?')
     run_generator
   end
 

spec/pixelpress_spec.rb

@@ -1,44 +1,47 @@
 require 'spec_helper'
 
 describe Pixelpress do
-  before(:all) { ActionController::Base.view_paths << File.join(spec_root) }
+  let(:renderer) { TestRenderer.new }
 
-  class Invoice
-    include ActiveModel::Model
-
-    attr_accessor :company_invoice
+  before(:each) do
+    ActionController::Base.view_paths << File.join(spec_root)
+    InvoicePrinter.default_renderer = renderer
   end
 
   class InvoicePrinter < Pixelpress::Base
-    # layout "pdf"
-
-    def invoice; end
+    def invoice
+    end
 
     def file_name
       'sasha'
     end
   end
 
-  it 'selects the right template' do
-    expect(InvoicePrinter.invoice.send(:template)).to eq 'printers/invoice/invoice'
+  class TestRenderer
+    attr_accessor :called
+
+    def render(html)
+      self.called = true
+      ""
+    end
   end
 
-  it 'does output some html' do
-    expect(InvoicePrinter.invoice.html).to include 'sasha'
+  it 'selects the right template' do
+    expect(InvoicePrinter.invoice.html).to include 'Invoice'
   end
 
   it 'checks if the file name of pdf is correct' do
     printer = InvoicePrinter.invoice.pdf
     expect(printer.original_filename).to eq 'sasha'
   end
 
-  it 'checks if render method renders html' do
-    html = InvoicePrinter.invoice.send :render, 'printers/invoice/invoice'
-    expect(html).to include '<html>'
+  it 'checks if it is calling weasyprinter when html is called' do
+    InvoicePrinter.invoice.html
+    expect(renderer.called).to be_falsy
   end
 
-  it 'checks if it is calling weasyprinter when html is called' do
-    result = InvoicePrinter.invoice.html
-    expect(result).not_to include '%PDF-1.5'
+  fit 'checks if it is calling weasyprinter when pdf is called' do
+    InvoicePrinter.invoice.pdf
+    expect(renderer.called).to be_truthy
   end
 end