Skip to content

Commit 0f4e1b7

Browse files
authored
update schemars to version 1 (#5128)
<!-- Thank you for contributing to nervosnetwork/ckb! If you haven't already, please read [CONTRIBUTING](https://github.com/nervosnetwork/ckb/blob/develop/CONTRIBUTING.md) document. If you're unsure about anything, just ask; somebody should be along to answer within a day or two. **Important**: We use Squash Merge to merge PRs, so the PR title will become the commit message. Please ensure your PR title follows the [Conventional Commit Messages](https://www.conventionalcommits.org/) format. The most important prefixes you should use: - `fix:`: represents bug fixes, and results in a SemVer patch bump. - `feat:`: represents a new feature, and results in a SemVer minor bump. - `<prefix>!:` (e.g. `feat!:`): represents a breaking change (indicated by the !) and results in a SemVer major bump. Other conventional prefixes are also acceptable (e.g., `docs:`, `refactor:`, `test:`, `chore:`, etc.). --> ### What problem does this PR solve? Previously ckb depends on `ckb_schemars`, a fork of `schemars` 0.8 to generate JSON schema for OpenRPC spec. Version 0.8 is too old for fiber to use. ### What is changed and how it works? This PR updates the dependency to `jsonrpc-utils` to a version that uses schemars 1.0, and replace `ckb_schemars` with `schemars` 1.0 ### Related changes - PR to update `owner/repo`: - Need to cherry-pick to the release branch ### Check List <!--REMOVE the items that are not applicable--> Tests <!-- At least one of them must be included. --> - Unit test - Integration test - Manual test (add detailed scripts or steps below) - No code Side effects - Performance regression - Breaking backward compatibility
1 parent 79d9cdb commit 0f4e1b7

6 files changed

Lines changed: 838 additions & 450 deletions

File tree

Cargo.lock

Lines changed: 62 additions & 41 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,7 @@ ignored = ["ckb-test"]
122122
[workspace.dependencies]
123123
tempfile = "3"
124124
itertools = "0.11.0"
125-
# issue tracking: https://github.com/GREsau/schemars/pull/251
126-
schemars = { package = "ckb_schemars", version = "0.8.22" }
125+
schemars = "1"
127126
anyhow = "1.0.34"
128127
arc-swap = "1.3"
129128
async-stream = "0.3.3"
@@ -253,7 +252,7 @@ ipnetwork = "0.20"
253252
is-terminal = "0.4.7"
254253
is_sorted = "0.1.1"
255254
jsonrpc-core = "18.0"
256-
jsonrpc-utils = "0.5"
255+
jsonrpc-utils = "0.6"
257256
keyed_priority_queue = "0.3"
258257
libc = "0.2"
259258
linked-hash-map = "0.5"

0 commit comments

Comments
 (0)