Filters::spacelessHtml() Add support for use <script> as link to JS

composer.json

@@ -29,15 +29,15 @@
 		"nette/utils": "to use filter |webalize"
 	},
 	"conflict": {
-		"nette/application": "<2.4.1"
+		"nette/application": "<3.0"
 	},
 	"autoload": {
 		"classmap": ["src/"]
 	},
 	"minimum-stability": "dev",
 	"extra": {
 		"branch-alias": {
-			"dev-master": "2.5-dev"
+			"dev-master": "3.0-dev"
 		}
 	}
 }

src/Latte/Engine.php

@@ -17,7 +17,7 @@ class Engine
 {
 	use Strict;
 
-	public const VERSION = '2.5.2';
+	public const VERSION = '3.0-dev';
 
 	/** Content types */
 	public const

src/Latte/Macros/BlockMacros.php

@@ -268,6 +268,9 @@ public function macroBlock(MacroNode $node, PhpWriter $writer)
 				return "\$this->checkBlockContentType($blockType, $fname);"
 					. "\$this->blockQueue[$fname][] = [\$this, '{$node->data->func}'];";
 			}
+
+		} elseif ($name[0] === '_') {
+			throw new CompileException("Block name '$name' must not start with an underscore.");
 		}
 
 		// static snippet/snippetArea

src/Latte/Runtime/Filters.php

@@ -316,26 +316,33 @@ public static function strip(FilterInfo $info, string $s): string
 	 * @param  bool  $strip  stripping mode
 	 * @return string HTML
 	 */
-	public static function spacelessHtml(string $s, int $phase = null, bool &$strip = true): string
+	public static function spacelessHtml(string $s, ?int $phase = null, bool &$strip = true): string
 	{
 		if ($phase & PHP_OUTPUT_HANDLER_START) {
 			$s = ltrim($s);
 		}
 		if ($phase & PHP_OUTPUT_HANDLER_FINAL) {
 			$s = rtrim($s);
 		}
-		return preg_replace_callback(
+		$return = (string) preg_replace_callback( // Other cases
 			'#[ \t\r\n]+|<(/)?(textarea|pre|script)(?=\W)#si',
-			function ($m) use (&$strip) {
+			static function (array $m) use (&$strip): string {
 				if (empty($m[2])) {
-					return $strip ? ' ' : $m[0];
-				} else {
-					$strip = !empty($m[1]);
-					return $m[0];
+					return (string) $strip ? ' ' : $m[0];
 				}
+				$strip = !empty($m[1]);
+				return (string) $m[0];
 			},
 			$s
 		);
+		$return = (string) preg_replace_callback( // <script> for include JS file
+			'/<script\s*([^>]+?)>(?:\s*)<\/script>/',
+			static function (array $m) use (&$strip): string {
+				return $strip ? '<script ' . trim(preg_replace('/\s+/', ' ', $m[1])) . '></script>' : (string) $m[0];
+			},
+			$return
+		);
+		return $return;
 	}
 
 

src/Latte/Runtime/ISnippetBridge.php

@@ -16,17 +16,17 @@
  */
 interface ISnippetBridge
 {
-	function isSnippetMode();
+	function isSnippetMode(): bool;
 
-	function setSnippetMode($snippetMode);
+	function setSnippetMode(bool $snippetMode);
 
-	function needsRedraw($name);
+	function needsRedraw(string $name): bool;
 
-	function markRedrawn($name);
+	function markRedrawn(string $name): void;
 
-	function getHtmlId($name);
+	function getHtmlId(string $name): string;
 
-	function addSnippet($name, $content);
+	function addSnippet(string $name, string $content): void;
 
-	function renderChildren();
+	function renderChildren(): void;
 }

tests/Latte/BlockMacros.block5.phpt

@@ -26,3 +26,7 @@ Assert::match(
 	'<br class="123">',
 	$latte->renderToString('{block test}<br n:class="$var">{/block}', ['var' => 123])
 );
+
+Assert::exception(function () use ($latte) {
+	$latte->renderToString('{define _foobar}Hello{/define}');
+}, Latte\CompileException::class, "Block name '_foobar' must not start with an underscore.");

tests/Latte/mocks/SnippetBridge.php

@@ -18,33 +18,33 @@ public function isSnippetMode(): bool
 	}
 
 
-	public function setSnippetMode($snippetMode)
+	public function setSnippetMode(bool $snippetMode)
 	{
 		$this->snippetMode = $snippetMode;
 	}
 
 
-	public function needsRedraw($name): bool
+	public function needsRedraw(string $name): bool
 	{
 		return $this->invalid === true || isset($this->invalid[$name]);
 	}
 
 
-	public function markRedrawn($name): void
+	public function markRedrawn(string $name): void
 	{
 		if ($this->invalid !== true) {
 			unset($this->invalid[$name]);
 		}
 	}
 
 
-	public function getHtmlId($name): string
+	public function getHtmlId(string $name): string
 	{
 		return $name;
 	}
 
 
-	public function addSnippet($name, $content): void
+	public function addSnippet(string $name, string $content): void
 	{
 		$this->payload[$name] = $content;
 	}