Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs in associating Gsheet and CCV #25

Open
jcohenadad opened this issue Oct 29, 2024 · 5 comments
Open

Bugs in associating Gsheet and CCV #25

jcohenadad opened this issue Oct 29, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@jcohenadad
Copy link
Member

jcohenadad commented Oct 29, 2024

Using my latest CCV-98720.xml.zip, I noticed serious bugs. Eg:

J163->J17: Shimming Toolbox: An open-source software toolbox for B0 and B1 shimming in Magnetic Resonance Imaging
J176->?: Calibration-free parallel transmission of the cervical, thoracic, and lumbar spinal cord at 7T
J179->J12: RF shimming in the cervical spinal cord at 7 T
C221->C34: RF shimming in the spinal cord at 7T
C243->C3: Calibration-Free Parallel Transmission of the Cervical, Thoracic, and Lumbar Spinal Cord at 7T
C248->C7: Towards UHF Spinal Cord MRI: Overcoming B0 & B1+ Challenges
C249->C7: Towards UHF Spinal Cord MRI: Overcoming B0 & B1+ Challenges
J168->?: Dynamic shimming in the cervical spinal cord for multi-echo gradient-echo imaging at 3 T
C170->C97: Real-time shimming in the cervical spinal cord using an 8-channel AC/DC array and a capacitive respiratory sensor
C180->C66: Real-Time Z-Shimming for Magnetic Resonance Imaging of the Spinal Cord
C191->C66: Real-Time Z-Shimming for Magnetic Resonance Imaging of the Spinal Cord
J168->?: Dynamic shimming in the cervical spinal cord for multi-echo gradient-echo imaging at 3 T
C230->C10: Dynamic shimming of the spinal cord using a 15-channel AC/DC coil

This is highly problematic (and urgent)

@jcohenadad jcohenadad added the bug Something isn't working label Oct 29, 2024
@jcohenadad
Copy link
Member Author

I suspect that maybe the presence of the asterisks on the downloaded XML partly cause this issue?

I know there are other issues related to the duplication of the title.

@namgo
Copy link
Member

namgo commented Oct 29, 2024

I'm looking into this today, you might be right that the presence of asterisks are causing confusion in what I understand to be a fuzzy matching system. This might be as easy as removing asterisks from the matching function.

I think stripping out the asterisks on both ends (xml and gsheet) automatically and then re-adding them after should make this work again - at least that's what I'm trying. So far I've removed the names from xml, next up is gsheet.

@namgo
Copy link
Member

namgo commented Oct 30, 2024

I've been working through this and have the partial solution I mentioned above implemented. The authors don't mismatch so much now.

None of the conf-* sections are matching properly, but I reverted to an earlier commit and this seemed to happen before.

There's still major issues I believe, J176 (for example) still goes completely unmatched.

@jcohenadad could you post the command you ran to get the above?

Additionally, can you confirm what the bug is and what the expected behaviour is?

@jcohenadad
Copy link
Member Author

@jcohenadad could you post the command you ran to get the above?

bibeasy -x /Users/julien/Library/CloudStorage/[email protected]/My\ Drive/Grants/20240707_NSERC-Discovery/CCV-98720.xml -i biblio.txt 

with biblio.txt being just a text that includes all the refs i want to convert (J163, etc.)

@namgo
Copy link
Member

namgo commented Nov 12, 2024

@jcohenadad still working on this but there were some neuropoly computers issues that popped up.

I have a branch (locally) with some changes that I believe are a starting point, but I'm pretty sure that there's something else causing the bug here, so it's taking some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants