Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page generation for pull request #121

Open
jcohenadad opened this issue Apr 23, 2024 · 5 comments
Open

Add page generation for pull request #121

jcohenadad opened this issue Apr 23, 2024 · 5 comments
Assignees

Comments

@jcohenadad
Copy link
Member

in SCT (and many other projects) we have the documentation built, that we can check on the pull request, without having to build the site locally on our computer. Example (see last check):

image

Would it be possible to implement such feature also for this repository?

@namgo namgo self-assigned this Apr 23, 2024
@namgo
Copy link
Member

namgo commented Apr 23, 2024

This is a little tricky because if a page isn't accessible from a parent it's a warning, and setting all warnings as errors would fail a few existing pages. Maybe this is a good opportunity to fix some of the missing links.

I'll proceed with cleaning up the docs in a different PR, but https://stackoverflow.com/questions/33896196/how-to-test-the-validity-of-your-sphinx-documentation will be what makes up the basis for "make test".

Edit:

make dummy was added semi-recently, I'll check how the warning syntax looks in gh actions. Might be all I need to do.

@nullnik-0
Copy link
Contributor

If I'm understanding correctly, I think the question is about having a PR preview feature similar to what is offered by Read the Docs, which allows one to preview site changes directly in pull requests, so that a local build is not needed to preview changes? If so, maybe something like Netlify would be a good solution here?

@jcohenadad
Copy link
Member Author

If I'm understanding correctly, I think the question is about having a PR preview feature similar to what is offered by Read the Docs, which allows one to preview site changes directly in pull requests, so that a local build is not needed to preview changes?

yes, that's exactly it

If so, maybe something like Netlify would be a good solution here?

Only if this is not too complicated to put in place. The feature is not sooooo needed, as it's not the end of the world to build locally or to publish, and then fix later on (although this is not great practice)

@namgo
Copy link
Member

namgo commented Apr 23, 2024

Ooooh! That makes perfect sense, thanks @nullnik-0 !!

@nullnik-0 nullnik-0 assigned nullnik-0 and unassigned namgo Apr 24, 2024
@nullnik-0
Copy link
Contributor

@namgo and I have been talking. I've reassigned this task to myself and will look into the Netlify solution a bit more when I get a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants