Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail locally #44

Open
mathurinm opened this issue Apr 14, 2023 · 0 comments
Open

Tests fail locally #44

mathurinm opened this issue Apr 14, 2023 · 0 comments

Comments

@mathurinm
Copy link
Contributor

#43 fixes few failures, but some remain:

========================================================================= short test summary info =========================================================================
FAILED tests/test_linear_regression.py::TestLinearRegression::test_large - ValueError: not enough values to unpack (expected 2, got 1)
FAILED tests/test_linear_regression_large.py::test_weights_vs_sklearn - AttributeError: 'Ridge' object has no attribute 'coef_'
FAILED tests/test_logistic_regression.py::TestLogisticRegression::test_large - ValueError: not enough values to unpack (expected 2, got 1)
FAILED tests/test_logistic_regression_large.py::test_weights_vs_sklearn - AttributeError: 'LogisticRegression' object has no attribute 'coef_'
FAILED tests/test_multiblock.py::TestMultiblock::test_multiblock_fista - AttributeError: 'MultiblockFunctionWrapper' object has no attribute 'at_point'
FAILED tests/test_svd.py::TestSVD::test_fast_sparse_svd - ValueError: not enough values to unpack (expected 2, got 1)
FAILED tests/test_svd.py::TestSVD::test_svd_adjacency_laplacian_coincide - AssertionError: 44.91093483101495 != 44.91093483101497

The "has no attribute coef_" hints at sklearn estimators not being fitted.

Also, the tests take 5 minutes to run. Launching solvers on smaller data may make them faster and thus improve the feedback loop when running the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant