Skip to content

Conversation

@alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Jan 22, 2026

  • Tests written, or not not needed

@alperozturk96
Copy link
Collaborator Author

/backport to stable-3.35

@alperozturk96 alperozturk96 force-pushed the fix/upload-sync-conflict-handling branch from e7acf86 to 74479e6 Compare January 22, 2026 08:26
@alperozturk96 alperozturk96 added this to the Nextcloud App 3.35.1 milestone Jan 22, 2026
@alperozturk96 alperozturk96 force-pushed the fix/upload-sync-conflict-handling branch from 0453b59 to 134cd4a Compare January 22, 2026 09:08
@alperozturk96 alperozturk96 requested a review from ZetaTom January 22, 2026 09:09
return null;
}

public void handleLocalBehaviour() {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private handleLocalBehaviour already used internally no need to call this outside from the UploadFileOperation.

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the fix/upload-sync-conflict-handling branch from 9886842 to ff1f785 Compare January 22, 2026 14:54
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions
Copy link

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions
Copy link

Codacy

SpotBugs

CategoryBaseNew
Bad practice4343
Correctness7474
Dodgy code256256
Experimental11
Internationalization77
Malicious code vulnerability33
Multithreaded correctness3434
Performance4343
Security1818
Total479479

@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16336.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@alperozturk96 alperozturk96 merged commit 5bdebb2 into master Jan 23, 2026
16 of 21 checks passed
@alperozturk96 alperozturk96 deleted the fix/upload-sync-conflict-handling branch January 23, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants