Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the project dead? #352

Open
talesam opened this issue Mar 2, 2023 · 10 comments
Open

Is the project dead? #352

talesam opened this issue Mar 2, 2023 · 10 comments

Comments

@talesam
Copy link

talesam commented Mar 2, 2023

I'm using version 25 of nextcloud and it looks like it's not supported, it's like experimental, but I turned it on I thought it would work but it doesn't, the project hasn't been committed for a long time, is it dead?

When I try to login I get a message saying:

"Internal Server Error
The server was unable to complete your request.

If this happens again, please send the technical details below to your server administrator.

More details can be found in the server log.

Technical details
Remote address: XXX.XXX.XXX.XXX
Order ID: fGdQAdh5GCfasdfrLXEWX"

@hellkaim
Copy link

hellkaim commented Mar 5, 2023

I ma not a project owner by any means but it seems it is at least dormant. I think we have to find new maintainers and fork it as I am not sure the author is sill here to accept the transfer (

@nerzhul
Copy link
Collaborator

nerzhul commented Mar 13, 2023

Hello, i don't have time to invest on it, especially when majority of people are nowadays using private platforms or signal. App sound be compatible with any nextcloud version as it doesn't rely on specific nextcloud code

@hellkaim
Copy link

Hello.
We do very well understand that your interest/priorities has being shifted from the project.

Mean while despite the really grate app and it's overall independence from NC there are issue that I will try to address in some near future. It would be nice if you could take a look on a request when it will be ready.

The main thing is new NC interface and new NC app info subsystems. The last one is FullTextSearch compitability.

@daraelmin
Copy link

Good morning,

Is it possible to assign an additional person the possibility of validating certain PRs?

If so, and even though I haven't been involved in the project so far, I'm willing to, to some degree.

Indeed, being more of a long-time user than a contributor to the project, I don't yet know the code well enough to be able to consider following the development of the project even less to become a source of proposals. So it seems difficult for me to imagine taking a leading role or validating new features at this time, but I'm willing to commit to testing and validating security and compatibility PRs.

Good day

@nerzhul
Copy link
Collaborator

nerzhul commented Jun 23, 2023

Hello, currently no one has adopted the project, and the app sync part is pretty complicated and blurry to rebuild.
If anyone is interested and can provide PR i'll review/merge then transfer ownership

@floss4good
Copy link

Hello @nerzhul,

First of all, for the part which must be rebuilt are you referring only to the server side sync code (the methods exposed by ApiController class) or also the code from the Android app?

Secondly, is there any urgent issue concerning the sync part?
I am asking because the sync still works, at least with Nextcloud Server v25 (I do need to periodically use the 'Reinit synchronization cursor' functionality from the Android app, but this is a very old issue). Therefore, from my point of view, the main issues would the the ones related with DB migration + broken CSS for NC v25 (#347) + removal of AppFramework/Db/Mapper for NC v26 (#353).

@adi2k5
Copy link

adi2k5 commented Jul 25, 2023

Secondly, is there any urgent issue concerning the sync part? I am asking because the sync still works, at least with Nextcloud Server v25 (I do need to periodically use the 'Reinit synchronization cursor' functionality from the Android app, but this is a very old issue). Therefore, from my point of view, the main issues would the the ones related with DB migration + broken CSS for NC v25 (#347) + removal of AppFramework/Db/Mapper for NC v26 (#353).

App will not work anymore with NC 27 and onwards due to drop of legacy class autoloader - see nextcloud/server#36114 and https://docs.nextcloud.com/server/stable/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_27.html#removal-of-psr-0-class-loader .
For me personally ocsms was working more or less without any big changes done since over 10 versions of NC, NC upgrades were complaining that app is not compatible and will be disabled, but at the end, they were not disabling ocsms in any way. I also haven't even needed to manualy sync, as it was syncing automatically without problems, but now, after moving to NC27, it seems that the game is over unfortunately.

@nerzhul
Copy link
Collaborator

nerzhul commented Aug 1, 2023

if anyone wants to repair application and maintain it go ahead, the sync part is pretty in its own place. I don't remember the scope of the autoloader, maybe not a big deal to change

@xlla
Copy link

xlla commented Jan 23, 2025

hi @nerzhul .
I want to repair this wonderful project and maintain it to go ahead.

For server side:

I have prepared a development env for NC 30, and manage to get the migration steps work.

php occ app:enable ocsms
ocsms 2.3.0 enabled


php occ migrations:status ocsms
    >> App:                                                ocsms
    >> Version Table Name:                                 oc_migrations
    >> Migrations Namespace:                               OCA\OcSms\Migration
    >> Migrations Directory:                               /var/www/html/custom_apps/ocsms/lib/Migration
    >> Previous Version:                                   020109Date20250113165830
    >> Current Version:                                    020300Date20210926000100
    >> Next Version:                                       Already at latest migration step
    >> Latest Version:                                     020300Date20210926000100
    >> Executed Migrations:                                4
    >> Executed Unavailable Migrations:                    4
    >> Available Migrations:                               4
    >> New Migrations:                                     4
    >> Pending Migrations:                                 None

I have create more migration class to keep up table and index changes introduced by NC update or original ocsms upgrade.
I have migrate to attributes from annotations for each xxxController.
I have migrate to QBMapper for each xxxMapper.
I have migrate to OCP\IPhoneNumberUtil to eliminate external PhoneNumberUtil dependencies.

For phone side:
I have upgrade the targetsdk to android sdk 32, and manage to get it run on android 12.
I have merge the PR221

It seems work for the initial fresh sync.

"url":"/index.php/apps/ocsms/push?format=json","message":"Controller OCA\\OcSms\\Controller\\ApiController::push executed 715 queries.","userAgent":"nextcloud-phonesync-go (2.0.7)","version":"30.0.4.1","data":{"app":"ocsms"}}

I can't get old version server side ocsms app enabled on NC28 and I can't install old version android app, so I can't test the data migration.

@nerzhul
Copy link
Collaborator

nerzhul commented Jan 23, 2025

Hello @xlla , feel free to open a PR. If someone wants to maintain this work, don't hesitate, i don't have much time/interest in the project currently as i'm not using much SMS nowadays

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants