Collaborative Editing - Renaming file makes the removes the file from the folder

[pedropintosilva]

This issue was originally reported by @Ezinnem

---

This bug occurs in Richdocuments 8.5.3 version in both single user and Collaborative users in a Shared folder

Seen during collaboratve editing on 2024-12-24 using COOLWSD version: 24.04.11.1(git hash: 3d3b1895f7 (E)) LOKit version: Collabora Office 24.04.11.1(git hash: 4459677)

A simpler step:

Open a folder using a shared URL
Open a file in that folder
Rename the file

See error:

If the file is reloaded, the file will be missing the folder

Screencast_from_24-12-24_15_54_17.webm

[jazevedo-coll]

A bisect of richdocuments indicates that this is the commit from which this behavior started happening;

565f825bf613cd49de5c42c6ed777baa4321c612 is the first bad commit
commit 565f825bf613cd49de5c42c6ed777baa4321c612
Author: Elizabeth Danzberger <lizzy7128@tutanota.de>
Date:   Wed Nov 13 12:04:51 2024 -0500

    fix: do not treat guest as share owner
    
    Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>

 lib/Controller/DocumentController.php    | 19 +++++++++++----
 lib/Controller/WopiController.php        | 40 ++++++++++++--------------------
 lib/TokenManager.php                     | 39 ++++++++++++++++++++++++-------
 tests/features/bootstrap/WopiContext.php | 30 ++++++++++++++++++++++++
 tests/features/wopi.feature              | 16 +++++++++++++
 5 files changed, 107 insertions(+), 37 deletions(-)

I checked the previous commit. And it was ok.

Commit: 565f825

From these merge requests:

#4306
Backport: #4310

Which seems to be to address this issue: #3830

[pedropintosilva]

cc: @elzody

[elzody]

Thanks, I will take a look at it when I can

[eszkadev]

As UX improvement we could also indicate in the CheckFileInfo from richdocuments that file cannot be renamed, eg. in shared folder? (if it is true)

and COOL then can block the option in the UI (show grey lock on the field? and tooltip explaining - the lack of permission)

I didn't check if it is done but would be nice improvement

[jazevedo-coll]

We also tested this fix our side and it solve the issue.

Thanks for the fix @elzody