refactor(core): improve TwoFactorMiddleware clarity and maintainability #70990
joshtrichardsstatic-code-analysis.yml
on: pull_request
static-code-analysis
1m 56s
static-code-analysis-security
5m 50s
static-code-analysis-ocp
50s
static-code-analysis-ncu
40s
Annotations
9 errors
|
static-code-analysis
Process completed with exit code 2.
|
|
ImplementedReturnTypeMismatch:
core/Middleware/TwoFactorMiddleware.php#L142
core/Middleware/TwoFactorMiddleware.php:142:13: ImplementedReturnTypeMismatch: The inherited return type 'OCP\AppFramework\Http\Response' for OCP\AppFramework\Middleware::afterException is different to the implemented return type for OC\Core\Middleware\TwoFactorMiddleware::afterexception 'OCP\AppFramework\Http\RedirectResponse|null' (see https://psalm.dev/123)
|
|
TaintedCallable:
lib/private/ServerContainer.php#L89
lib/private/ServerContainer.php:89:17: TaintedCallable: Detected tainted text (see https://psalm.dev/243)
|
|
TaintedHtml:
lib/private/Mail/Mailer.php#L227
lib/private/Mail/Mailer.php:227:72: TaintedHtml: Detected tainted HTML (see https://psalm.dev/245)
|
|
TaintedHtml:
lib/private/Mail/Mailer.php#L207
lib/private/Mail/Mailer.php:207:83: TaintedHtml: Detected tainted HTML (see https://psalm.dev/245)
|
|
TaintedCallable:
lib/private/AppFramework/Utility/SimpleContainer.php#L129
lib/private/AppFramework/Utility/SimpleContainer.php:129:33: TaintedCallable: Detected tainted text (see https://psalm.dev/243)
|
|
TaintedCallable:
apps/workflowengine/lib/Manager.php#L501
apps/workflowengine/lib/Manager.php:501:39: TaintedCallable: Detected tainted text (see https://psalm.dev/243)
|
|
TaintedCallable:
apps/workflowengine/lib/Manager.php#L468
apps/workflowengine/lib/Manager.php:468:38: TaintedCallable: Detected tainted text (see https://psalm.dev/243)
|
|
TaintedCallable:
apps/workflowengine/lib/Manager.php#L426
apps/workflowengine/lib/Manager.php:426:38: TaintedCallable: Detected tainted text (see https://psalm.dev/243)
|