Merge pull request #51438 from nextcloud/perf/db/cards-properties-abid-name-value-idx

perf(db): Extend index on cards_properties to cover name and value

Author: kesselb

apps/dav/lib/Migration/Version1004Date20170924124212.php

@@ -28,7 +28,10 @@ public function changeSchema(IOutput $output, \Closure $schemaClosure, array $op
 		$table->addIndex(['addressbookid', 'uri'], 'cards_abiduri');
 
 		$table = $schema->getTable('cards_properties');
-		$table->addIndex(['addressbookid'], 'cards_prop_abid');
+		// Removed later on
+		// $table->addIndex(['addressbookid'], 'cards_prop_abid');
+		// Added later on
+		$table->addIndex(['addressbookid', 'name', 'value'], 'cards_prop_abid_name_value', );
 
 		return $schema;
 	}

core/Application.php

@@ -147,12 +147,12 @@ public function __construct() {
 				true
 			);
 
-			$event->addMissingIndex(
+			$event->replaceIndex(
 				'cards_properties',
-				'cards_prop_abid',
-				['addressbookid'],
-				[],
-				true
+				['cards_prop_abid'],
+				'cards_prop_abid_name_value',
+				['addressbookid', 'name', 'value'],
+				false,
 			);
 
 			$event->addMissingIndex(