-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Tons of errors generated from /app/www/public/3rdparty/wapmorgan/mp3info/ #44573
Comments
I suspect the reason you're seeing this so frequently is because you're using the As to the underlying cause, that's a different matter. I assume you have some MP3 files among your Nextcloud data files? The spot where this is happening (in a 3rd party library) suggests to me that the codec or layer versions (one or both) are coming up empty on at least one of your MP3 files. You may be able to figure out what file it is by running https://github.com/nextcloud/previewgenerator?tab=readme-ov-file#commands Lastly, there may be opportunity to explore having the Cc: @kesselb |
Upstream PR created to generate an informative exception when this happens: wapmorgan/Mp3Info#36 |
Thanks for your reply.
Yes, you are right. I have a crontab running
Indeed, I see mp3 files in the logs generated from the previewgenerator.
Here is a snip of the file output with -vvv flag:
There is no error in the log. Excluding mp3 files from previewgenerator seems unrealistic. And it will still generate errors while a user browse the folder with mp3 in it. |
Not the cause of your situation, but https://github.com/nextcloud/previewgenerator?tab=readme-ov-file#how-to-use-the-app |
The reason I run
|
Oh, gotcha. nextcloud/previewgenerator#218 maybe? |
Good find! Thanks for the info. I think I have reported this years ago but no fixing was planned at that time. |
@joshtrichards |
I have edited the config.php to exclude MP3 files from preview generation. It helps to cut down the errors generated. Now only 63 errors since Mar 30. |
just tried to manually patch @joshtrichards changes from wapmorgan/Mp3Info#36 and i can confirm the errors flood have stopped without additional issue when reading metadata or listening mp3. edit: i came here cuz bug is live with NC 29.0.1 |
@joshtrichards wdyt about removing the mp3 preview provider? |
did you resolve problem in NC 29.01? |
Yes, after edition, it is indeed solved in my instance of NC29.0.1 (I would still have to patch it again after an update, tho) |
Same here. Got thousands of those same errors every second. Don't have preview generator active either.
Not quite sure what app is causing this as im using a very slimmed down nextcloud for just filestorage basically. |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
Tip: Disable the mp3 preview provider and you don't see the warning anymore in the logs. |
This comment was marked as duplicate.
This comment was marked as duplicate.
As I don't know how do disable it inside the Music app, I disabled the app... |
I think you can disable mp3 preview by adding an 'enabledPreviewProviders' section in config.php without the ''OC\Preview\MP3',' line as explained here. |
in the meantime, since i don't want to whitelist what preview i want to keep or not, i made a patch file that i reapply after every updates --- Mp3Info.old.php 2024-06-08 15:17:44.000000000 +0200
+++ Mp3Info.new.php 2024-06-08 15:15:59.000000000 +0200
@@ -384,6 +384,9 @@
case 0b11: $this->layerVersion = self::LAYER_1; break;
}
+ if (!isset($this->codecVersion) || !isset($this->layerVersion) || !isset($header_bytes[2])) {
+ throw new \Exception('Unrecognized codecVersion or layerVersion headers!');
+ }
$this->bitRate = self::$_bitRateTable[$this->codecVersion][$this->layerVersion][$header_bytes[2] >> 4];
$this->sampleRate = self::$_sampleRateTable[$this->codecVersion][($header_bytes[2] >> 2) & 0b11];
@@ -394,6 +397,9 @@
case 0b11: $this->channel = self::MONO; break;
}
+ if (!isset($this->channel)) {
+ throw new \Exception('Unrecognized channel header!');
+ }
$vbr_offset = self::$_vbrOffsets[$this->codecVersion][$this->channel == self::MONO ? 0 : 1];
// check for VBR |
HOW? |
Please follow these instructions: |
This comment was marked as duplicate.
This comment was marked as duplicate.
the bug is still present in 29.0.3, any update when it will be fixed? |
The patch at wapmorgan/Mp3Info#36 (slightly updated today) can be applied if you can't wait for a maintenance release. The file to update/replace in your Nextcloud installation folder is at We'll patch the version we distribute w/ Server in the next maintenance release regardless of the status of the upstream PR merge. P.S. There's no need to post "me too / still happening" comments. It just creates noise for everyone and wasted time/resources (which slows down development... such as for bug fixes). Just upvote 👍 the initial report above (unless you have something useful to add that'll help resolve an issue of course). The 👍 is how, in part, we prioritize issues. Ironically no one has yet 👍 the initial report above. :) |
Also existing in 29.0.4. I thought, that should be fixed?
It even crashed my instance since disk was full. What can I do? |
Please log a new issue, provide the requested information (don't forget the logs) and we will take a look. |
Bug description
There are tons of error generated from /app/www/public/3rdparty/wapmorgan/mp3info/
From the section of Security & setup warnings on web interface, Administration->Overview
"25718 errors in the logs since 22 March 2024"
Steps to reproduce
Expected behavior
No error reported from the section Security & setup warnings
Installation method
Community Docker image
Nextcloud Server version
28
Operating system
Debian/Ubuntu
PHP engine version
PHP 8.3
Web server
Nginx
Database engine version
MariaDB
Is this bug present after an update or on a fresh install?
Upgraded to a MAJOR version (ex. 22 to 23)
Are you using the Nextcloud Server Encryption module?
Encryption is Disabled
What user-backends are you using?
Configuration report
List of activated Apps
# occ app:list Enabled: - activity: 2.20.0 - circles: 28.0.0 - cloud_federation_api: 1.11.0 - comments: 1.18.0 - contactsinteraction: 1.9.0 - dashboard: 7.8.0 - dav: 1.29.1 - federatedfilesharing: 1.18.0 - federation: 1.18.0 - files: 2.0.0 - files_external: 1.20.0 - files_pdfviewer: 2.9.0 - files_reminders: 1.1.0 - files_rightclick: 1.6.0 - files_sharing: 1.20.0 - files_trashbin: 1.18.0 - files_versions: 1.21.0 - firstrunwizard: 2.17.0 - logreader: 2.13.0 - lookup_server_connector: 1.16.0 - nextcloud_announcements: 1.17.0 - notifications: 2.16.0 - oauth2: 1.16.3 - password_policy: 1.18.0 - previewgenerator: 5.4.0 - privacy: 1.12.0 - provisioning_api: 1.18.0 - recommendations: 2.0.0 - related_resources: 1.3.0 - serverinfo: 1.18.0 - settings: 1.10.1 - sharebymail: 1.18.0 - support: 1.11.1 - survey_client: 1.16.0 - suspicious_login: 6.0.0 - systemtags: 1.18.0 - text: 3.9.1 - theming: 2.3.0 - twofactor_backupcodes: 1.17.0 - twofactor_totp: 10.0.0-beta.2 - updatenotification: 1.18.0 - user_status: 1.8.1 - viewer: 2.2.0 - weather_status: 1.8.0 - workflowengine: 2.10.0 Disabled: - admin_audit: 1.18.0 - bruteforcesettings: 2.8.0 - encryption: 2.16.0 - photos: 2.4.0 (installed 2.3.0) - user_ldap: 1.19.0
Nextcloud Signing status
Nextcloud Logs
Additional info
No response
The text was updated successfully, but these errors were encountered: