[Bug]: Undefined array key "storage_string_id" at /apps/files_sharing/lib/SharedStorage.php#483

[alx-tuilmenau]

⚠️ This issue respects the following points: ⚠️

• This is a bug, not a question or a configuration/webserver/proxy issue.
• This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
• Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
• I agree to follow Nextcloud's Code of Conduct.

Bug description

After updating from 29.0.10 to 29.0.11.1, I got lots of errors in the Nextcloud logfile, all of the same kind for a WebDAV PROPFIND operation with different filenames.

Steps to reproduce

1. Update to 29.0.11
2. Sync files via WebDAV
3. See logfile

Expected behavior

No errors in log

Nextcloud Server version

29

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.2

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Updated from a MINOR version (ex. 28.0.1 to 28.0.2)

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

• Default user-backend (database)
• LDAP/ Active Directory
• SSO - SAML
• Other

Configuration report

{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "XXX",
            "XXX"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "29.0.11.1",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "dbdriveroptions": {
            "1002": "SET wait_timeout = 28800"
        },
        "installed": true,
        "default_language": "de",
        "updatechecker": true,
        "has_internet_connection": true,
        "memcached_servers": [
            [
                "localhost",
                11211
            ]
        ],
        "appstoreenabled": true,
        "ldapIgnoreNamingRules": false,
        "ldapProviderFactory": "\\OCA\\User_LDAP\\LDAPProviderFactory",
        "loglevel": 2,
        "trusted_proxies": "***REMOVED SENSITIVE VALUE***",
        "forwarded_for_headers": [
            "HTTP_X_FORWARDED_FOR"
        ],
        "overwritehost": "XXX",
        "overwriteprotocol": "https",
        "overwrite.cli.url": "XXX",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpmode": "smtp",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "skeletondirectory": "\/data\/nextcloud_skel",
        "activity_expire_days": 14,
        "integrity.check.disabled": true,
        "memcache.local": "\\OC\\Memcache\\APCu",
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 6379,
            "password": "***REMOVED SENSITIVE VALUE***"
        },
        "knowledgebaseenabled": false,
        "defaultapp": "",
        "sharing.minSearchStringLength": 4,
        "sharing.maxAutocompleteResults": 5,
        "maintenance": false,
        "debug": false,
        "htaccess.RewriteBase": "\/",
        "proxy": "XXX",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "25",
        "updater.release.channel": "stable",
        "lookup_server": "",
        "app_install_overwrite": [
            "quotaadmin",
            "drop_account",
            "gpxedit",
            "twofactor_u2f",
            "metadata",
            "files_mindmap"
        ],
        "enable_previews": true,
        "preview_max_x": 700,
        "preview_max_y": 700,
        "preview_max_scale_factor": 2,
        "tempdirectory": "\/data\/tmp\/nextcloud",
        "localstorage.allowsymlinks": true,
        "hashingMemoryCost": 8,
        "default_phone_region": "de",
        "upgrade.disable-web": true,
        "preview_max_filesize_image": 20,
        "enabledPreviewProviders": [
            "OC\\Preview\\PNG",
            "OC\\Preview\\JPEG",
            "OC\\Preview\\GIF",
            "OC\\Preview\\BMP",
            "OC\\Preview\\XBitmap",
            "OC\\Preview\\MP3",
            "OC\\Preview\\TXT",
            "OC\\Preview\\MarkDown"
        ],
        "profile.enabled": false,
        "lost_password_link": "disabled",
        "bulkupload.enabled": false,
        "trashbin_retention_obligation": "auto, 14",
        "versions_retention_obligation": "auto, 14",
        "maintenance_window_start": 18,
        "files_no_background_scan": true
    }
}

List of activated Apps

- activity: 2.21.1
  - announcementcenter: 7.0.1
  - bruteforcesettings: 2.9.0
  - calendar: 4.7.16
  - circles: 29.0.0-dev
  - cloud_federation_api: 1.12.0
  - collectives: 2.15.2
  - comments: 1.19.0
  - contacts: 6.0.2
  - contactsinteraction: 1.10.0
  - dav: 1.30.1
  - deck: 1.13.3
  - drawio: 3.0.3
  - drop_account: 2.6.1
  - federatedfilesharing: 1.19.0
  - federation: 1.19.0
  - files: 2.1.1
  - files_antivirus: 5.6.1
  - files_downloadactivity: 1.17.0
  - files_downloadlimit: 2.0.0
  - files_mindmap: 0.0.32
  - files_pdfviewer: 2.10.0
  - files_reminders: 1.2.0
  - files_retention: 1.18.0
  - files_sharing: 1.21.0
  - files_trashbin: 1.19.0
  - files_versions: 1.22.0
  - forms: 4.3.5
  - guests: 3.2.0
  - login_notes: 1.6.1
  - logreader: 2.14.0
  - lookup_server_connector: 1.17.0
  - metadata: 0.21.0
  - notes: 4.11.0
  - notifications: 2.17.0
  - oauth2: 1.17.1
  - photos: 2.5.0
  - polls: 7.2.9
  - provisioning_api: 1.19.0
  - quota_warning: 1.20.0
  - quotaadmin: 0.0.5
  - recommendations: 2.1.0
  - related_resources: 1.4.0
  - serverinfo: 1.19.0
  - settings: 1.12.0
  - sharebymail: 1.19.0
  - spreed: 19.0.12
  - systemtags: 1.19.0
  - tables: 0.8.3
  - tasks: 0.16.1
  - text: 3.10.1
  - theming: 2.4.0
  - theming_customcss: 1.18.0
  - twofactor_backupcodes: 1.18.0
  - twofactor_totp: 11.0.0-dev
  - twofactor_webauthn: 1.4.0
  - updatenotification: 1.19.1
  - user_ldap: 1.20.0
  - viewer: 2.3.0
  - whiteboard: 1.0.4
  - workflowengine: 2.11.0

Nextcloud Signing status

Integrity checker has been disabled. Integrity cannot be verified.

Nextcloud Logs

{"reqId":"XXX","level":3,"time":"2025-01-17T13:43:47+00:00","remoteAddr":"XXX","user":"XXX","app":"PHP","method":"PROPFIND","url":"/remote.php/dav/files/fXXX","message":"Undefined array key \"storage_string_id\" at /data/nextcloud_a2/apps/files_sharing/lib/SharedStorage.php#483","userAgent":"Mozilla/5.0 (Linux) mirall/3.12.0-20240214.183952.1c1e752c4-1.0~jammy1 (Nextcloud, ubuntu-6.5.0-21-generic ClientArchitecture: x86_64 OsArchitecture: x86_64)","version":"29.0.11.1","data":{"app":"PHP"}}

Additional info

The code at the error position is this:

$node = $this->getShare()->getNodeCacheEntry();
if ($node instanceof CacheEntry) {
           $storageId = $node->getData()['storage_string_id'];  // <---- error line

I tried to find something, but the $node there does not contain the key storage_string_id, it looks like there are only the columns from the filecache table, so only the numerical storageid is there. I don't know where this is generated / comes from, the $this->getShare() returns a IShare supershare attribute, which is set via $arguments in the constructor, so I don't know how to fix it.

[kesselb]

cc @icewind1991 @juliusknorr

[alx-tuilmenau]

Maybe it is caused by this change: 926b9d3

Edit: Reverting this change seems to solve the problem, but I don't know if this will break something other elsewhere.

[solracsf]

Patch has been merged and will be released on v29.0.13, v30.0.7 and v31.

[gonzalo]

@solracsf Me and my 250,000 error logs at day salute you!