Skip to content

Migrate UsersRepository+UserManager to coroutines #4609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mahibi opened this issue Jan 15, 2025 · 0 comments
Open

Migrate UsersRepository+UserManager to coroutines #4609

mahibi opened this issue Jan 15, 2025 · 0 comments
Assignees
@mahibi
Labels
1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees)

Comments

@mahibi
Copy link
Collaborator

mahibi commented Jan 15, 2025

Classes related to Users, e.g.

  • UsersRepository
  • UserManager
  • CurrentUserProviderImpl
    have to be migrated from RxJava to coroutines.

Similar to the current implementation with RxJava, in CurrentUserProviderImpl a coldFlow to hotFlow conversion has to be made so the database is not queried every time.

userManager.currentUser.blockingGet() (or it's coroutine pendent) should not be queried throughout the code but CurrentUserProviderImpl should be used instead.
@mahibi mahibi added the 1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) label Jan 15, 2025
@mahibi mahibi self-assigned this Jan 15, 2025
@mahibi mahibi mentioned this issue Jan 15, 2025
Merged
5 tasks
@mahibi mahibi mentioned this issue Jan 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mahibi mahibi

Labels
1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mahibi