Skip to content

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Nov 13, 2025

☑️ Resolves

🖼️ Screenshots

image image image image image image image image image

@ShGKme ShGKme added this to the 🎒 Backlog milestone Nov 13, 2025
@ShGKme ShGKme self-assigned this Nov 13, 2025
@ShGKme ShGKme added enhancement New feature or request 2. developing labels Nov 13, 2025
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it should be there or in the Conversation+ menu?

Or maybe via the search field in the left sidebar?

}

if (!maybeConversationUrl.startsWith(appData.serverUrl!)) {
return { error: t('talk_desktop', 'Opening conversations from other servers is not currently supported'), token: '' }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return { error: t('talk_desktop', 'Opening conversations from other servers is not currently supported'), token: '' }
return { error: t('talk_desktop', 'Opening conversations from other servers is currently not supported'), token: '' }

@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 14, 2025

Not sure it should be there or in the Conversation+ menu?

I'd prefer something that will also work for joining as a guest in the future. And if possible - more visible.

Or maybe via the search field in the left sidebar?

This sounds nice but seems a bit hidden to the end user. You need to know that you can past a link to the search field. And still handle errors.

@Antreesy
Copy link
Contributor

  • do it on the web, for example, on the Dashboard.

Sound good, that would match competitors:

image image

Can we do a component in spreed and use it with @talk/src in desktop?

@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 14, 2025

Can we do a component in spreed and use it with @talk/src in desktop?

I am unsure if I understand what component you want to add and where to use, but in general we should never directly use files from talk in desktop or vise versa. It should be a public API, like API to extend one app by another we have in other apps.

For example, we may have the link/component on the web all the time, but have slightly different handling or optional handler registration in the future when the multi account is supported.

@Antreesy
Copy link
Contributor

Antreesy commented Nov 14, 2025

Essentialy, public API to spawn a dialog window from this PR would be more than enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Join a conversation from the same server by entering a direct link

4 participants