-
Notifications
You must be signed in to change notification settings - Fork 59
[DRAFT] feat(talk): add "Join by link" action #1541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Grigorii K. Shartsev <[email protected]>
0c781e8 to
111f2b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure it should be there or in the Conversation+ menu?
Or maybe via the search field in the left sidebar?
| } | ||
|
|
||
| if (!maybeConversationUrl.startsWith(appData.serverUrl!)) { | ||
| return { error: t('talk_desktop', 'Opening conversations from other servers is not currently supported'), token: '' } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| return { error: t('talk_desktop', 'Opening conversations from other servers is not currently supported'), token: '' } | |
| return { error: t('talk_desktop', 'Opening conversations from other servers is currently not supported'), token: '' } |
I'd prefer something that will also work for joining as a guest in the future. And if possible - more visible.
This sounds nice but seems a bit hidden to the end user. You need to know that you can past a link to the search field. And still handle errors. |
I am unsure if I understand what component you want to add and where to use, but in general we should never directly use files from talk in desktop or vise versa. It should be a public API, like API to extend one app by another we have in other apps. For example, we may have the link/component on the web all the time, but have slightly different handling or optional handler registration in the future when the multi account is supported. |
|
Essentialy, public API to spawn a dialog window from this PR would be more than enough |


☑️ Resolves
🖼️ Screenshots