Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display links inserted from smart picker as page title/file name #6180

Open
NikoKS opened this issue Aug 7, 2024 · 2 comments
Open

Display links inserted from smart picker as page title/file name #6180

NikoKS opened this issue Aug 7, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@NikoKS
Copy link

NikoKS commented Aug 7, 2024

This request has been made in collectives Issues page nextcloud/collectives#949, but was mistakenly addressed by #5838.

In short, it would be better when links added by smart picker to another pages to have the title/file name of the page picked. This is similar to the behavior when referring to a github page from another text. For example, I want to refer an issue in a sentence like #5838, instead of embedding an entire preview of the page in another line.

Having a preview of the page would make sense when the link is not in the middle of a sentence. But when it is, it would be better to only show the title.

@NikoKS NikoKS added the enhancement New feature or request label Aug 7, 2024
@juliushaertl
Copy link
Member

I think this makes sense. I looked into inserting inline links automatically with their actual title in the past (still have a wip commit in c98c8f4), but back then it was tricky as we needed a separate request to get the metadata from the smart picker API, maybe this works better now, so we would not need the whole logic for a separate node type there.

@NikoKS
Copy link
Author

NikoKS commented Sep 4, 2024

Hello @juliushaertl, it's great to hear that it might be implementable now! Is there any plan on implementing it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants