Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for the daisybio profile #737

Merged
merged 14 commits into from
Aug 21, 2024

Conversation

JohannesKersting
Copy link
Contributor

@JohannesKersting JohannesKersting commented Aug 20, 2024


name: daisybio
about: Update for the daisybio profile

New additions:

  • workDirs are created in a centralized scratch location to track and remove them easier
  • workDirs are cleaned by default, but can be kept with the keep_work profile
  • singularity and apptainer are loaded as environment modules

Please follow these steps before submitting your PR:

  • If your PR is a work in progress, include [WIP] in its title
  • Your PR targets the master branch
  • You've included links to relevant issues, if any

Steps for adding a new config profile:

  • Add your custom config file to the conf/ directory
  • Add your documentation file to the docs/ directory
  • Add your custom profile to the nfcore_custom.config file in the top-level directory
  • Add your custom profile to the README.md file in the top-level directory
  • Add your profile name to the profile: scope in .github/workflows/main.yml

Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Only thing is the keep_work profile might not be necessary as nf-core comes with one my default called debug (https://github.com/nf-core/tools/blob/master/nf_core%2Fpipeline-template%2Fnextflow.config#L88-L93)

But it comes with extra bells and whistles you might not want, so up to you

@JohannesKersting
Copy link
Contributor Author

Thanks for the review!

I am aware of the debug option, but afaik will also produce more verbose logging, etc.
The keep_work option is not really meant for debugging, but, e.g., for a scenario where an RNA-seq pipeline first runs on a couple of samples but additional samples might arrive in the future.

@JohannesKersting JohannesKersting merged commit ca9e531 into nf-core:master Aug 21, 2024
127 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants