Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dataset links and tags of nextclade to be compatible with v3+ #787

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

Joon-Klaps
Copy link
Contributor


name: New Config
about: A new cluster config

Linked to nf-core/viralrecon#446 and nf-core/test-datasets#1378

Please follow these steps before submitting your PR:

  • If your PR is a work in progress, include [WIP] in its title
  • Your PR targets the master branch
  • You've included links to relevant issues, if any

Steps for adding a new config profile:

  • Add your custom config file to the conf/ directory
  • Add your documentation file to the docs/ directory
  • Add your custom profile to the nfcore_custom.config file in the top-level directory
  • Add your custom profile to the README.md file in the top-level directory
  • Add your profile name to the profile: scope in .github/workflows/main.yml
  • OPTIONAL: Add your custom profile path and GitHub user name to .github/CODEOWNERS (**/<custom-profile>** @<github-username>)

Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 💯 familiar with this type of genomes.config (I didn't realise we allowed non-instutional configs here), but conceptually looks OK to me :)

@Joon-Klaps Joon-Klaps merged commit 047fa8c into master Nov 5, 2024
271 checks passed
@Joon-Klaps Joon-Klaps deleted the viralrecon-nextclade-patch branch November 5, 2024 10:31
@robsyme
Copy link

robsyme commented Nov 5, 2024

As mentioned here, I think this breaks the viralrecon pipeline using the test profile. The current version of viralrecon uses nextclade v2.12, which is not compatible with these references.

I'd recommend rolling this back and thinking about putting these references under a different flag?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants