You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Many thanks for taking an interest in improving nf-core/plantpathsurveil.
4
+
Many thanks for taking an interest in improving nf-core/pathogensurveillance.
5
5
6
-
We try to manage the required tasks for nf-core/plantpathsurveil using GitHub issues, you probably came to this page when creating one.
6
+
We try to manage the required tasks for nf-core/pathogensurveillance using GitHub issues, you probably came to this page when creating one.
7
7
Please use the pre-filled template to save time.
8
8
9
9
However, don't be put off by this template - other more general issues and suggestions are welcome!
10
10
Contributions to the code are even more welcome ;)
11
11
12
12
> [!NOTE]
13
-
> If you need help using or modifying nf-core/plantpathsurveil then the best place to ask is on the nf-core Slack [#plantpathsurveil](https://nfcore.slack.com/channels/plantpathsurveil) channel ([join our Slack here](https://nf-co.re/join/slack)).
13
+
> If you need help using or modifying nf-core/pathogensurveillance then the best place to ask is on the nf-core Slack [#pathogensurveillance](https://nfcore.slack.com/channels/pathogensurveillance) channel ([join our Slack here](https://nf-co.re/join/slack)).
14
14
15
15
## Contribution workflow
16
16
17
-
If you'd like to write some code for nf-core/plantpathsurveil, the standard workflow is as follows:
17
+
If you'd like to write some code for nf-core/pathogensurveillance, the standard workflow is as follows:
18
18
19
-
1. Check that there isn't already an issue about your idea in the [nf-core/plantpathsurveil issues](https://github.com/nf-core/plantpathsurveil/issues) to avoid duplicating work. If there isn't one already, please create one so that others know you're working on this
20
-
2.[Fork](https://help.github.com/en/github/getting-started-with-github/fork-a-repo) the [nf-core/plantpathsurveil repository](https://github.com/nf-core/plantpathsurveil) to your GitHub account
19
+
1. Check that there isn't already an issue about your idea in the [nf-core/pathogensurveillance issues](https://github.com/nf-core/pathogensurveillance/issues) to avoid duplicating work. If there isn't one already, please create one so that others know you're working on this
20
+
2.[Fork](https://help.github.com/en/github/getting-started-with-github/fork-a-repo) the [nf-core/pathogensurveillance repository](https://github.com/nf-core/pathogensurveillance) to your GitHub account
21
21
3. Make the necessary changes / additions within your forked repository following [Pipeline conventions](#pipeline-contribution-conventions)
22
22
4. Use `nf-core pipelines schema build` and add any new parameters to the pipeline JSON schema (requires [nf-core tools](https://github.com/nf-core/tools) >= 1.10).
23
23
5. Submit a Pull Request against the `dev` branch and wait for the code to be reviewed and merged
@@ -55,23 +55,23 @@ These tests are run both with the latest available version of `Nextflow` and als
55
55
56
56
:warning: Only in the unlikely and regretful event of a release happening with a bug.
57
57
58
-
- On your own fork, make a new branch `patch` based on `upstream/master`.
58
+
- On your own fork, make a new branch `patch` based on `upstream/main` or `upstream/master`.
59
59
- Fix the bug, and bump version (X.Y.Z+1).
60
-
-A PR should be made on `master`from patch to directly this particular bug.
60
+
-Open a pull-request from `patch` to `main`/`master`with the changes.
61
61
62
62
## Getting help
63
63
64
-
For further information/help, please consult the [nf-core/plantpathsurveil documentation](https://nf-co.re/plantpathsurveil/usage) and don't hesitate to get in touch on the nf-core Slack [#plantpathsurveil](https://nfcore.slack.com/channels/plantpathsurveil) channel ([join our Slack here](https://nf-co.re/join/slack)).
64
+
For further information/help, please consult the [nf-core/pathogensurveillance documentation](https://nf-co.re/pathogensurveillance/usage) and don't hesitate to get in touch on the nf-core Slack [#pathogensurveillance](https://nfcore.slack.com/channels/pathogensurveillance) channel ([join our Slack here](https://nf-co.re/join/slack)).
65
65
66
66
## Pipeline contribution conventions
67
67
68
-
To make the nf-core/plantpathsurveil code and processing logic more understandable for new contributors and to ensure quality, we semi-standardise the way the code and other contributions are written.
68
+
To make the `nf-core/pathogensurveillance` code and processing logic more understandable for new contributors and to ensure quality, we semi-standardise the way the code and other contributions are written.
69
69
70
70
### Adding a new step
71
71
72
72
If you wish to contribute a new step, please use the following coding standards:
73
73
74
-
1. Define the corresponding input channel into your new process from the expected previous process channel
74
+
1. Define the corresponding input channel into your new process from the expected previous process channel.
75
75
2. Write the process block (see below).
76
76
3. Define the output channel if needed (see below).
77
77
4. Add any new parameters to `nextflow.config` with a default (see below).
@@ -84,7 +84,7 @@ If you wish to contribute a new step, please use the following coding standards:
84
84
85
85
### Default values
86
86
87
-
Parameters should be initialised / defined with default values in `nextflow.config` under the `params` scope.
87
+
Parameters should be initialised / defined with default values within the `params` scope in `nextflow.config`.
88
88
89
89
Once there, use `nf-core pipelines schema build` to add to `nextflow_schema.json`.
90
90
@@ -115,7 +115,7 @@ This repo includes a devcontainer configuration which will create a GitHub Codes
115
115
116
116
To get started:
117
117
118
-
- Open the repo in [Codespaces](https://github.com/nf-core/plantpathsurveil/codespaces)
118
+
- Open the repo in [Codespaces](https://github.com/nf-core/pathogensurveillance/codespaces)
Copy file name to clipboardexpand all lines: .github/PULL_REQUEST_TEMPLATE.md
+5-5
Original file line number
Diff line number
Diff line change
@@ -1,22 +1,22 @@
1
1
<!--
2
-
# nf-core/plantpathsurveil pull request
2
+
# nf-core/pathogensurveillance pull request
3
3
4
-
Many thanks for contributing to nf-core/plantpathsurveil!
4
+
Many thanks for contributing to nf-core/pathogensurveillance!
5
5
6
6
Please fill in the appropriate checklist below (delete whatever is not relevant).
7
7
These are the most common things requested on pull requests (PRs).
8
8
9
9
Remember that PRs should be made against the dev branch, unless you're preparing a pipeline release.
10
10
11
-
Learn more about contributing: [CONTRIBUTING.md](https://github.com/nf-core/plantpathsurveil/tree/master/.github/CONTRIBUTING.md)
11
+
Learn more about contributing: [CONTRIBUTING.md](https://github.com/nf-core/pathogensurveillance/tree/master/.github/CONTRIBUTING.md)
12
12
-->
13
13
14
14
## PR checklist
15
15
16
16
-[ ] This comment contains a description of changes (with reason).
17
17
-[ ] If you've fixed a bug or added code that should be tested, add tests!
18
-
-[ ] If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/plantpathsurveil/tree/master/.github/CONTRIBUTING.md)
19
-
-[ ] If necessary, also make a PR on the nf-core/plantpathsurveil_branch_ on the [nf-core/test-datasets](https://github.com/nf-core/test-datasets) repository.
18
+
-[ ] If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/pathogensurveillance/tree/master/.github/CONTRIBUTING.md)
19
+
-[ ] If necessary, also make a PR on the nf-core/pathogensurveillance_branch_ on the [nf-core/test-datasets](https://github.com/nf-core/test-datasets) repository.
20
20
-[ ] Make sure your code lints (`nf-core pipelines lint`).
21
21
-[ ] Ensure the test suite passes (`nextflow run . -profile test,docker --outdir <OUTDIR>`).
22
22
-[ ] Check for unexpected warnings in debug mode (`nextflow run . -profile debug,test,docker --outdir <OUTDIR>`).
## This PR is against the `${{github.event.pull_request.base.ref}}` branch :x:
26
28
27
29
* Do not close this PR
28
30
* Click _Edit_ and change the `base` to `dev`
@@ -32,9 +34,9 @@ jobs:
32
34
33
35
Hi @${{ github.event.pull_request.user.login }},
34
36
35
-
It looks like this pull-request is has been made against the [${{github.event.pull_request.head.repo.full_name }}](https://github.com/${{github.event.pull_request.head.repo.full_name }}) `master` branch.
36
-
The `master` branch on nf-core repositories should always contain code from the latest release.
37
-
Because of this, PRs to `master` are only allowed if they come from the [${{github.event.pull_request.head.repo.full_name }}](https://github.com/${{github.event.pull_request.head.repo.full_name }}) `dev` branch.
37
+
It looks like this pull-request is has been made against the [${{github.event.pull_request.head.repo.full_name }}](https://github.com/${{github.event.pull_request.head.repo.full_name }}) ${{github.event.pull_request.base.ref}} branch.
38
+
The ${{github.event.pull_request.base.ref}} branch on nf-core repositories should always contain code from the latest release.
39
+
Because of this, PRs to ${{github.event.pull_request.base.ref}} are only allowed if they come from the [${{github.event.pull_request.head.repo.full_name }}](https://github.com/${{github.event.pull_request.head.repo.full_name }}) `dev` branch.
38
40
39
41
You do not need to close this PR, you can change the target branch to `dev` by clicking the _"Edit"_ button at the top of this page.
40
42
Note that even after this, the test will continue to show as failing until you push a new commit.
0 commit comments