Fix configure script (after fb85dac) (ntop#1381)

Fix/disable some LGTM warnings

Author: IvanNardi

.gitignore

@@ -75,3 +75,6 @@ stamp-h1
 /tests/dga/dga_evaluate
 /tests/unit/unit
 /tags
+/rrdtool/Makefile
+/rrdtool/rrd_anomaly
+/rrdtool/rrd_similarity

configure.ac

@@ -110,7 +110,7 @@ AC_CHECK_LIB([rrd], [rrd_fetch_r], [LIBRRD=-lrrd])
 
 if test "x$ac_cv_lib_rrd_rrd_fetch_r" = xyes; then :
    AC_DEFINE_UNQUOTED(HAVE_RRDTOOL, "1", [rrdtool is present])
-   EXTRA_TARGETS="rrdtool"
+   EXTRA_TARGETS="$EXTRA_TARGETS rrdtool"
 fi
 
 ADDITIONAL_LIBS="$LIBRRD $LIBM"

example/ndpiReader.c

@@ -1188,7 +1188,7 @@ static char* is_unsafe_cipher(ndpi_cipher_weakness c) {
 /* ********************************** */
 
 void print_bin(FILE *fout, const char *label, struct ndpi_bin *b) {
-  u_int8_t i;
+  u_int16_t i;
   const char *sep = label ? "," : ";";
 
   ndpi_normalize_bin(b);

lgtm.yml

@@ -0,0 +1,2 @@
+queries:
+  - exclude: cpp/cleartext-storage-file

src/lib/ndpi_main.c

@@ -3010,7 +3010,7 @@ int ndpi_add_host_risk_mask(struct ndpi_detection_module_struct *ndpi_str,
 int ndpi_handle_rule(struct ndpi_detection_module_struct *ndpi_str, char *rule, u_int8_t do_add) {
   char *at, *proto, *elem;
   ndpi_proto_defaults_t *def;
-  u_int16_t subprotocol_id, i;
+  u_int subprotocol_id, i;
 
   at = strrchr(rule, '@');
   if(at == NULL) {
@@ -3061,7 +3061,7 @@ int ndpi_handle_rule(struct ndpi_detection_module_struct *ndpi_str, char *rule,
     }
   }
 
-  for(i = 0, def = NULL; i < (int) ndpi_str->ndpi_num_supported_protocols; i++) {
+  for(i = 0, def = NULL; i < ndpi_str->ndpi_num_supported_protocols; i++) {
     if(ndpi_str->proto_defaults[i].protoName
        && strcasecmp(ndpi_str->proto_defaults[i].protoName, proto) == 0) {
       def = &ndpi_str->proto_defaults[i];