Skip to content

Commit acadd02

Browse files
Removed outdated security monitoring package
1 parent ebc4a50 commit acadd02

File tree

3 files changed

+10
-22
lines changed

3 files changed

+10
-22
lines changed

nginx-instance-manager/docker-deployment/Dockerfile.manual

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
FROM ubuntu:22.04@sha256:1ec65b2719518e27d4d25f104d93f9fac60dc437f81452302406825c46fcc9cb
22

33
ARG NIM_DEBFILE
4-
ARG SM_IMAGE=nim-files/.placeholder
54
ARG PUM_IMAGE=nim-files/.placeholder
65

76
# Initial setup
@@ -12,7 +11,6 @@ RUN apt-get update && \
1211

1312
# NGINX Instance Manager 2.4.0+
1413
COPY $NIM_DEBFILE /deployment/setup/nim.deb
15-
COPY $SM_IMAGE /deployment/setup/sm.deb
1614
COPY $PUM_IMAGE /deployment/setup/pum.deb
1715

1816
COPY ./container/startNIM.sh /deployment/
@@ -24,9 +22,6 @@ COPY $NIM_DEBFILE /deployment/setup/nim.deb
2422

2523
RUN apt-get -y install /deployment/setup/nim.deb && \
2624
curl -s http://hg.nginx.org/nginx.org/raw-file/tip/xml/en/security_advisories.xml > /usr/share/nms/cve.xml \
27-
# Optional Security Monitoring
28-
&& if [ "$SM_IMAGE" != "nim-files/.placeholder" ] ; then \
29-
apt-get -y install /deployment/setup/sm.deb; fi \
3025
# Optional WAF Policy Compiler
3126
&& if [ "$PUM_IMAGE" != "nim-files/.placeholder" ] ; then \
3227
apt-get -y install /deployment/setup/pum.deb; fi \

nginx-instance-manager/docker-deployment/README.md

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ NGINX Instance Manager Docker image builder
5252
5353
-h - This help
5454
-t [target image] - Docker image name to be created
55-
-s - Enable Second Sight (https://github.com/F5Networks/SecondSight/) - optional
5655
5756
Manual build:
5857
@@ -65,20 +64,19 @@ NGINX Instance Manager Docker image builder
6564
-i - Automated build - requires cert & key
6665
-C [file.crt] - Certificate file to pull packages from the official NGINX repository
6766
-K [file.key] - Key file to pull packages from the official NGINX repository
68-
-W - Enable Security Monitoring - optional
69-
-P [version] - Enable WAF policy compiler, version can be any [v3.1088.2|v4.100.1|v4.2.0|v4.218.0|v4.279.0|v4.402.0|v4.457.0|v4.583.0] - optional
67+
-P [version] - Enable WAF policy compiler, version can be [v3.1088.2|v4.100.1|v4.2.0|v4.218.0|v4.279.0|v4.402.0|v4.457.0|v4.583.0|v4.641.0|v4.762.0|v4.815.0|v5.17.0|v5.48.0|v5.144.0|v5.210.0|v5.264.0|v5.342.0|v5.442.0] - optional
7068
7169
=== Examples:
7270
7371
Manual build:
74-
./scripts/buildNIM.sh -n nim-files/nms-instance-manager_2.6.0-698150575~focal_amd64.deb \
75-
-w nim-files/nms-sm_1.0.0-697204659~focal_amd64.deb \
76-
-p nim-files/nms-nap-compiler-v4.2.0.deb \
77-
-t my.registry.tld/nginx-nms:2.6.0
72+
./scripts/buildNIM.sh -t my-private-registry/nginx-instance-manager:2.15.1-nap-v4.815.0-manualbuild \
73+
-n nim-files/nms-instance-manager_2.15.1-1175574316~focal_amd64.deb \
74+
-w nim-files/nms-sm_1.7.1-1046510610~focal_amd64.deb \
75+
-p nim-files/nms-nap-compiler-v4.815.0_4.815.0-1~focal_amd64.deb
7876
7977
Automated build:
80-
./scripts/buildNIM.sh -i -C nginx-repo.crt -K nginx-repo.key
81-
-W -P v4.583.0 -t my.registry.tld/nginx-nms:latest
78+
./scripts/buildNIM.sh -i -C nginx-repo.crt -K nginx-repo.key \
79+
-P v5.144.0 -t my.registry.tld/nginx-nms:latest
8280
```
8381

8482
### Automated build

nginx-instance-manager/docker-deployment/scripts/buildNIM.sh

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,25 +9,23 @@ $0 [options]\n\n
99
-t [target image]\t- Docker image name to be created\n\n
1010
Manual build:\n\n
1111
-n [filename]\t\t- NGINX Instance Manager .deb package filename\n
12-
-w [filename]\t\t- Security Monitoring .deb package filename - optional\n
1312
-p [filename]\t\t- WAF policy compiler .deb package filename - optional\n\n
1413
Automated build:\n\n
1514
-i\t\t\t- Automated build - requires cert & key\n
1615
-C [file.crt]\t\t- Certificate file to pull packages from the official NGINX repository\n
1716
-K [file.key]\t\t- Key file to pull packages from the official NGINX repository\n
18-
-P [version]\t\t- Enable WAF policy compiler, version can be any [v3.1088.2|v4.100.1|v4.2.0|v4.218.0|v4.279.0|v4.402.0|v4.457.0|v4.583.0|v4.641|v4.762|v4.815.0|v5.17.0|v5.48.0|v5.144.0] - optional\n\n
17+
-P [version]\t\t- Enable WAF policy compiler, version can be [v3.1088.2|v4.100.1|v4.2.0|v4.218.0|v4.279.0|v4.402.0|v4.457.0|v4.583.0|v4.641.0|v4.762.0|v4.815.0|v5.17.0|v5.48.0|v5.144.0|v5.210.0|v5.264.0|v5.342.0|v5.442.0] - optional\n\n
1918
=== Examples:\n\n
2019
Manual build:\n
2120
\t$0 -t my-private-registry/nginx-instance-manager:2.15.1-nap-v4.815.0-manualbuild \\\\\\n
2221
\t\t-n nim-files/nms-instance-manager_2.15.1-1175574316~focal_amd64.deb \\\\\n
23-
\t\t-w nim-files/nms-sm_1.7.1-1046510610~focal_amd64.deb \\\\\n
2422
\t\t-p nim-files/nms-nap-compiler-v4.815.0_4.815.0-1~focal_amd64.deb\n\n
2523
Automated build:\n
2624
\t$0 -i -C nginx-repo.crt -K nginx-repo.key \\\\\n
2725
\t\t-P v5.144.0 -t my.registry.tld/nginx-nms:latest\n
2826
"
2927

30-
while getopts 'hn:w:p:t:siC:K:AP:' OPTION
28+
while getopts 'hn:p:t:siC:K:AP:' OPTION
3129
do
3230
case "$OPTION" in
3331
h)
@@ -37,9 +35,6 @@ do
3735
n)
3836
DEBFILE=$OPTARG
3937
;;
40-
w)
41-
SM_IMAGE=$OPTARG
42-
;;
4338
p)
4439
PUM_IMAGE=$OPTARG
4540
;;
@@ -90,7 +85,7 @@ echo "==> Building NGINX Management Suite docker image"
9085
if [ -z "${AUTOMATED_INSTALL}" ]
9186
then
9287
docker build --no-cache -f Dockerfile.manual --build-arg NIM_DEBFILE=$DEBFILE \
93-
--build-arg SM_IMAGE=$SM_IMAGE --build-arg PUM_IMAGE=$PUM_IMAGE -t $IMGNAME .
88+
--build-arg PUM_IMAGE=$PUM_IMAGE -t $IMGNAME .
9489
else
9590
DOCKER_BUILDKIT=1 docker build --no-cache -f Dockerfile.automated --secret id=nginx-key,src=$NGINX_KEY --secret id=nginx-crt,src=$NGINX_CERT \
9691
--build-arg ADD_PUM=$ADD_PUM \

0 commit comments

Comments
 (0)