Merge branch 'main' into tests/nfr-tests-edge

sjberman · web-flow · commit 133d380f344a · 2025-12-05T15:29:53.000-07:00
diff --git a/README.md b/README.md
@@ -68,7 +68,7 @@ The following table lists the software versions NGINX Gateway Fabric supports.
 
 | NGINX Gateway Fabric | Gateway API | Kubernetes | NGINX OSS | NGINX Plus | NGINX Agent |
 |----------------------|-------------|------------|-----------|------------|-------------|
-| Edge                 | 1.4.0       | 1.25+      | 1.29.3    | R36        | v3.5.1      |
+| Edge                 | 1.4.1       | 1.25+      | 1.29.3    | R36        | v3.5.1      |
 | 2.2.1                | 1.3.0       | 1.25+      | 1.29.2    | R35        | v3.5.0      |
 | 2.2.0                | 1.3.0       | 1.25+      | 1.29.2    | R35        | v3.3.2      |
 | 2.1.4                | 1.3.0       | 1.25+      | 1.29.1    | R35        | v3.3.1      |
diff --git a/build/ubi/Dockerfile b/build/ubi/Dockerfile
@@ -11,7 +11,7 @@ RUN make build
 
 FROM golang:1.25 AS ca-certs-provider
 
-FROM redhat/ubi9-minimal:9.7-1764578379 AS ngf-ubi-minimal
+FROM redhat/ubi9-minimal:9.7-1764794109 AS ngf-ubi-minimal
 # CA certs are needed for telemetry report so that NGF can verify the server's certificate.
 COPY --from=ca-certs-provider --link /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/
 USER 101:1001
@@ -33,11 +33,11 @@ COPY --link --chown=101:1001 LICENSE /licenses/
 ENTRYPOINT [ "/usr/bin/gateway" ]
 
 FROM ngf-ubi-minimal AS container
-COPY --from=builder /go/src/github.com/nginxinc/nginx-gateway-fabric/build/out/gateway /usr/bin/gateway
+COPY --chmod=0755 --from=builder /go/src/github.com/nginxinc/nginx-gateway-fabric/build/out/gateway /usr/bin/gateway
 
 FROM ngf-ubi-minimal AS local
-COPY ./build/out/gateway /usr/bin/gateway
+COPY --chmod=0755 ./build/out/gateway /usr/bin/gateway
 
 FROM ngf-ubi-minimal AS goreleaser
 ARG TARGETARCH
-COPY dist/gateway_linux_$TARGETARCH*/gateway /usr/bin/gateway
+COPY --chmod=0755 dist/gateway_linux_$TARGETARCH*/gateway /usr/bin/gateway
diff --git a/build/ubi/Dockerfile.nginx b/build/ubi/Dockerfile.nginx
@@ -8,7 +8,7 @@ ADD --link --chown=101:1001 build/ubi/repos/agent.repo agent.repo
 
 FROM ghcr.io/nginx/dependencies/nginx-ubi:ubi9@sha256:1bde412ee491e03e686f3f8cebe22dad0526e007d0d34829c143f063dca8084f AS ubi9-packages
 
-FROM redhat/ubi9-minimal:9.7-1764578379 AS ubi-nginx
+FROM redhat/ubi9-minimal:9.7-1764794109 AS ubi-nginx
 
 # renovate: datasource=github-tags depName=nginx/agent
 ARG NGINX_AGENT_VERSION=v3.5.1
diff --git a/build/ubi/Dockerfile.nginxplus b/build/ubi/Dockerfile.nginxplus
@@ -8,7 +8,7 @@ ADD --link --chown=101:1001 build/ubi/repos/agent.repo agent.repo
 
 FROM ghcr.io/nginx/dependencies/nginx-ubi:ubi9@sha256:1bde412ee491e03e686f3f8cebe22dad0526e007d0d34829c143f063dca8084f AS ubi9-packages
 
-FROM redhat/ubi9-minimal:9.7-1764578379 AS ubi-nginx-plus
+FROM redhat/ubi9-minimal:9.7-1764794109 AS ubi-nginx-plus
 
 ARG NGINX_PLUS_VERSION=R36
 
diff --git a/cmd/gateway/validation.go b/cmd/gateway/validation.go
@@ -12,7 +12,7 @@ import (
 )
 
 const (
-	// Regex from: https://github.com/kubernetes-sigs/gateway-api/blob/v1.4.0/apis/v1/shared_types.go#L675
+	// Regex from: https://github.com/kubernetes-sigs/gateway-api/blob/v1.4.1/apis/v1/shared_types.go#L675
 	controllerNameRegex = `^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*\/[A-Za-z0-9\/\-._~%!$&'()*+,;=:]+$` //nolint:lll
 )
 
diff --git a/config/crd/gateway-api/experimental/kustomization.yaml b/config/crd/gateway-api/experimental/kustomization.yaml
@@ -1,4 +1,4 @@
 apiVersion: kustomize.config.k8s.io/v1beta1
 kind: Kustomization
 resources:
-  - https://github.com/kubernetes-sigs/gateway-api/config/crd/experimental?timeout=120&ref=v1.4.0
+  - https://github.com/kubernetes-sigs/gateway-api/config/crd/experimental?timeout=120&ref=v1.4.1
diff --git a/config/crd/gateway-api/standard/kustomization.yaml b/config/crd/gateway-api/standard/kustomization.yaml
@@ -1,4 +1,4 @@
 apiVersion: kustomize.config.k8s.io/v1beta1
 kind: Kustomization
 resources:
-- https://github.com/kubernetes-sigs/gateway-api/config/crd?timeout=120&ref=v1.4.0
+- https://github.com/kubernetes-sigs/gateway-api/config/crd?timeout=120&ref=v1.4.1
diff --git a/docs/proposals/authentication-filter.md b/docs/proposals/authentication-filter.md
@@ -1,4 +1,4 @@
-# Enhancement Proposal-4052: Authentiation Filter
+# Enhancement Proposal-4052: Authentication Filter
 
 - Issue: https://github.com/nginx/nginx-gateway-fabric/issues/4052
 - Status: Implementable
diff --git a/go.mod b/go.mod
@@ -13,7 +13,7 @@ require (
 	github.com/onsi/ginkgo/v2 v2.27.2
 	github.com/onsi/gomega v1.38.2
 	github.com/prometheus/client_golang v1.23.2
-	github.com/spf13/cobra v1.10.1
+	github.com/spf13/cobra v1.10.2
 	github.com/spf13/pflag v1.0.10
 	go.opentelemetry.io/otel v1.38.0
 	go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.38.0
@@ -28,7 +28,7 @@ require (
 	k8s.io/client-go v0.34.2
 	k8s.io/klog/v2 v2.130.1
 	sigs.k8s.io/controller-runtime v0.22.4
-	sigs.k8s.io/gateway-api v1.4.0
+	sigs.k8s.io/gateway-api v1.4.1
 	sigs.k8s.io/gateway-api-inference-extension v1.1.0
 )
 
diff --git a/go.sum b/go.sum
@@ -209,8 +209,8 @@ github.com/spf13/afero v1.15.0 h1:b/YBCLWAJdFWJTN9cLhiXXcD7mzKn9Dm86dNnfyQw1I=
 github.com/spf13/afero v1.15.0/go.mod h1:NC2ByUVxtQs4b3sIUphxK0NioZnmxgyCrfzeuq8lxMg=
 github.com/spf13/cast v1.10.0 h1:h2x0u2shc1QuLHfxi+cTJvs30+ZAHOGRic8uyGTDWxY=
 github.com/spf13/cast v1.10.0/go.mod h1:jNfB8QC9IA6ZuY2ZjDp0KtFO2LZZlg4S/7bzP6qqeHo=
-github.com/spf13/cobra v1.10.1 h1:lJeBwCfmrnXthfAupyUTzJ/J4Nc1RsHC/mSRU2dll/s=
-github.com/spf13/cobra v1.10.1/go.mod h1:7SmJGaTHFVBY0jW4NXGluQoLvhqFQM+6XSKD+P4XaB0=
+github.com/spf13/cobra v1.10.2 h1:DMTTonx5m65Ic0GOoRY2c16WCbHxOOw6xxezuLaBpcU=
+github.com/spf13/cobra v1.10.2/go.mod h1:7C1pvHqHw5A4vrJfjNwvOdzYu0Gml16OCs2GRiTUUS4=
 github.com/spf13/pflag v1.0.9/go.mod h1:McXfInJRrz4CZXVZOBLb0bTZqETkiAhM9Iw0y3An2Bg=
 github.com/spf13/pflag v1.0.10 h1:4EBh2KAYBwaONj6b2Ye1GiHfwjqyROoF4RwYO+vPwFk=
 github.com/spf13/pflag v1.0.10/go.mod h1:McXfInJRrz4CZXVZOBLb0bTZqETkiAhM9Iw0y3An2Bg=
@@ -356,8 +356,8 @@ k8s.io/utils v0.0.0-20250820121507-0af2bda4dd1d h1:wAhiDyZ4Tdtt7e46e9M5ZSAJ/MnPG
 k8s.io/utils v0.0.0-20250820121507-0af2bda4dd1d/go.mod h1:OLgZIPagt7ERELqWJFomSt595RzquPNLL48iOWgYOg0=
 sigs.k8s.io/controller-runtime v0.22.4 h1:GEjV7KV3TY8e+tJ2LCTxUTanW4z/FmNB7l327UfMq9A=
 sigs.k8s.io/controller-runtime v0.22.4/go.mod h1:+QX1XUpTXN4mLoblf4tqr5CQcyHPAki2HLXqQMY6vh8=
-sigs.k8s.io/gateway-api v1.4.0 h1:ZwlNM6zOHq0h3WUX2gfByPs2yAEsy/EenYJB78jpQfQ=
-sigs.k8s.io/gateway-api v1.4.0/go.mod h1:AR5RSqciWP98OPckEjOjh2XJhAe2Na4LHyXD2FUY7Qk=
+sigs.k8s.io/gateway-api v1.4.1 h1:NPxFutNkKNa8UfLd2CMlEuhIPMQgDQ6DXNKG9sHbJU8=
+sigs.k8s.io/gateway-api v1.4.1/go.mod h1:AR5RSqciWP98OPckEjOjh2XJhAe2Na4LHyXD2FUY7Qk=
 sigs.k8s.io/gateway-api-inference-extension v1.1.0 h1:MqRYk+3LNUWB0MbTgTZVhmJGNDTvm8l3ze4MOlzR7MU=
 sigs.k8s.io/gateway-api-inference-extension v1.1.0/go.mod h1:BmJy8Hvc2EHl3Oa/Ka8/4RqwVHCCbX7BLndLdMNtugI=
 sigs.k8s.io/json v0.0.0-20250730193827-2d320260d730 h1:IpInykpT6ceI+QxKBbEflcR5EXP7sU1kvOlxwZh5txg=
diff --git a/internal/controller/provisioner/handler.go b/internal/controller/provisioner/handler.go
@@ -67,8 +67,10 @@ func (h *eventHandler) HandleEventBatch(ctx context.Context, logger logr.Logger,
 				objLabels := labels.Set(obj.GetLabels())
 				if h.labelSelector.Matches(objLabels) {
 					gatewayName := objLabels.Get(controller.GatewayLabel)
+					if gatewayName == "" {
+						gatewayName = obj.GetAnnotations()[controller.GatewayLabel]
+					}
 					gatewayNSName := types.NamespacedName{Namespace: obj.GetNamespace(), Name: gatewayName}
-
 					if err := h.updateOrDeleteResources(ctx, logger, obj, gatewayNSName); err != nil {
 						logger.Error(err, "error handling resource update")
 					}
@@ -77,12 +79,13 @@ func (h *eventHandler) HandleEventBatch(ctx context.Context, logger logr.Logger,
 				objLabels := labels.Set(obj.GetLabels())
 				if h.labelSelector.Matches(objLabels) {
 					gatewayName := objLabels.Get(controller.GatewayLabel)
+					if gatewayName == "" {
+						gatewayName = obj.GetAnnotations()[controller.GatewayLabel]
+					}
 					gatewayNSName := types.NamespacedName{Namespace: obj.GetNamespace(), Name: gatewayName}
-
 					if err := h.updateOrDeleteResources(ctx, logger, obj, gatewayNSName); err != nil {
 						logger.Error(err, "error handling resource update")
 					}
-
 					statusUpdate := &status.QueueObject{
 						Deployment:     client.ObjectKeyFromObject(obj),
 						UpdateType:     status.UpdateGateway,
@@ -94,8 +97,10 @@ func (h *eventHandler) HandleEventBatch(ctx context.Context, logger logr.Logger,
 				objLabels := labels.Set(obj.GetLabels())
 				if h.labelSelector.Matches(objLabels) {
 					gatewayName := objLabels.Get(controller.GatewayLabel)
+					if gatewayName == "" {
+						gatewayName = obj.GetAnnotations()[controller.GatewayLabel]
+					}
 					gatewayNSName := types.NamespacedName{Namespace: obj.GetNamespace(), Name: gatewayName}
-
 					if err := h.updateOrDeleteResources(ctx, logger, obj, gatewayNSName); err != nil {
 						logger.Error(err, "error handling resource update")
 					}
diff --git a/internal/controller/provisioner/objects.go b/internal/controller/provisioner/objects.go
@@ -90,12 +90,17 @@ func (p *NginxProvisioner) buildNginxResourceObjects(
 
 	selectorLabels := make(map[string]string)
 	maps.Copy(selectorLabels, p.baseLabelSelector.MatchLabels)
-	selectorLabels[controller.GatewayLabel] = gateway.GetName()
 	selectorLabels[controller.AppNameLabel] = resourceName
 
 	labels := make(map[string]string)
 	annotations := make(map[string]string)
 
+	if len(gateway.GetName()) > controller.MaxServiceNameLen {
+		annotations[controller.GatewayLabel] = gateway.GetName()
+	} else {
+		selectorLabels[controller.GatewayLabel] = gateway.GetName()
+	}
+
 	maps.Copy(labels, selectorLabels)
 
 	if gateway.Spec.Infrastructure != nil {
diff --git a/internal/controller/provisioner/provisioner.go b/internal/controller/provisioner/provisioner.go
@@ -2,6 +2,7 @@ package provisioner
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"slices"
 	"strings"
@@ -246,33 +247,35 @@ func (p *NginxProvisioner) provisionNginx(
 		createCtx, cancel := context.WithTimeout(ctx, 30*time.Second)
 
 		var res controllerutil.OperationResult
+		var upsertErr error
 		if err := wait.PollUntilContextCancel(
 			createCtx,
 			500*time.Millisecond,
 			true, /* poll immediately */
 			func(ctx context.Context) (bool, error) {
-				var upsertErr error
 				res, upsertErr = controllerutil.CreateOrUpdate(ctx, p.k8sClient, obj, objectSpecSetter(obj))
 				if upsertErr != nil {
-					if !apierrors.IsAlreadyExists(upsertErr) && !apierrors.IsConflict(upsertErr) {
-						return false, upsertErr
-					}
-					if apierrors.IsConflict(upsertErr) {
-						return false, nil
-					}
+					p.cfg.Logger.V(1).Info(
+						"Retrying CreateOrUpdate for nginx resource after error",
+						"namespace", gateway.GetNamespace(),
+						"name", resourceName,
+						"error", upsertErr.Error(),
+					)
+					return false, nil //nolint:nilerr // continue retrying
 				}
 				return true, nil
 			},
 		); err != nil {
+			fullErr := errors.Join(err, upsertErr)
 			p.cfg.EventRecorder.Eventf(
 				obj,
 				corev1.EventTypeWarning,
 				"CreateOrUpdateFailed",
 				"Failed to create or update nginx resource: %s",
-				err.Error(),
+				fullErr.Error(),
 			)
 			cancel()
-			return err
+			return fullErr
 		}
 		cancel()
 
@@ -327,6 +330,10 @@ func (p *NginxProvisioner) provisionNginx(
 			object = daemonSetObj
 		}
 
+		if object == nil {
+			return nil
+		}
+
 		p.cfg.Logger.V(1).Info(
 			"Restarting nginx after agent configmap update",
 			"name", object.GetName(),
diff --git a/internal/controller/provisioner/setter.go b/internal/controller/provisioner/setter.go
@@ -119,9 +119,7 @@ func serviceSpecSetter(
 		}
 
 		// Apply NGF-managed annotations (take precedence)
-		for k, v := range objectMeta.Annotations {
-			mergedAnnotations[k] = v
-		}
+		maps.Copy(mergedAnnotations, objectMeta.Annotations)
 
 		// Store current managed keys for next reconciliation
 		if len(currentManagedKeys) > 0 {
diff --git a/internal/controller/state/graph/backend_refs.go b/internal/controller/state/graph/backend_refs.go
@@ -14,7 +14,6 @@ import (
 	ngfAPIv1alpha2 "github.com/nginx/nginx-gateway-fabric/v2/apis/v1alpha2"
 	"github.com/nginx/nginx-gateway-fabric/v2/internal/controller/sort"
 	"github.com/nginx/nginx-gateway-fabric/v2/internal/controller/state/conditions"
-	"github.com/nginx/nginx-gateway-fabric/v2/internal/framework/controller"
 	"github.com/nginx/nginx-gateway-fabric/v2/internal/framework/helpers"
 	"github.com/nginx/nginx-gateway-fabric/v2/internal/framework/kinds"
 )
@@ -116,7 +115,7 @@ func addBackendRefsToRules(
 				}
 
 				poolName := types.NamespacedName{
-					Name:      controller.GetInferencePoolName(string(ref.Name)),
+					Name:      ref.InferencePoolName,
 					Namespace: namespace,
 				}
 
@@ -596,7 +595,7 @@ func validateBackendRefHTTPRoute(
 			inferencePool = true
 			inferencePoolName = types.NamespacedName{
 				Namespace: string(*ref.Namespace),
-				Name:      controller.GetInferencePoolName(string(ref.Name)),
+				Name:      ref.InferencePoolName,
 			}
 		default:
 			refNsName := types.NamespacedName{Namespace: string(*ref.Namespace), Name: string(ref.Name)}
diff --git a/internal/controller/state/graph/backend_refs_test.go b/internal/controller/state/graph/backend_refs_test.go
@@ -106,7 +106,8 @@ func TestValidateRouteBackendRef(t *testing.T) {
 					backend.Name = gatewayv1.ObjectName(controller.CreateInferencePoolServiceName("ipool"))
 					return backend
 				}),
-				IsInferencePool: true,
+				IsInferencePool:   true,
+				InferencePoolName: "ipool",
 			},
 			expectedValid: true,
 		},
@@ -393,7 +394,8 @@ func TestValidateBackendRefHTTPRoute(t *testing.T) {
 					backend.Namespace = helpers.GetPointer[gatewayv1.Namespace]("invalid")
 					return backend
 				}),
-				IsInferencePool: true,
+				IsInferencePool:   true,
+				InferencePoolName: "ipool",
 			},
 			refGrantResolver: alwaysFalseRefGrantResolver,
 			expectedValid:    false,
@@ -1220,6 +1222,7 @@ func TestAddBackendRefsToRules(t *testing.T) {
 				route := createRoute("hr-inference", RouteTypeHTTP, "Service", 1, svcInferenceName)
 				// Mark the backend ref as IsInferencePool and set the port to nil (simulate InferencePool logic)
 				route.Spec.Rules[0].RouteBackendRefs[0].IsInferencePool = true
+				route.Spec.Rules[0].RouteBackendRefs[0].InferencePoolName = "ipool"
 				route.Spec.Rules[0].RouteBackendRefs[0].Port = nil
 				return route
 			}(),
diff --git a/internal/controller/state/graph/graph_test.go b/internal/controller/state/graph/graph_test.go
@@ -239,7 +239,8 @@ func TestBuildGraph(t *testing.T) {
 		}
 		rbrs := []RouteBackendRef{
 			{
-				IsInferencePool: true,
+				IsInferencePool:   true,
+				InferencePoolName: "ipool",
 				BackendRef: gatewayv1.BackendRef{
 					BackendObjectReference: gatewayv1.BackendObjectReference{
 						Group:     helpers.GetPointer[gatewayv1.Group](""),
diff --git a/internal/controller/state/graph/httproute.go b/internal/controller/state/graph/httproute.go
@@ -224,7 +224,7 @@ func processHTTPRouteRule(
 		// If route specifies an InferencePool backend, we need to convert it to its associated
 		// headless Service backend (that we created), so nginx config can be built properly.
 		// Only do this if the InferencePool actually exists.
-		if inferencePoolBackend(b, routeNamespace, inferencePools) {
+		if ok, key := inferencePoolBackend(b, routeNamespace, inferencePools); ok {
 			// We don't support traffic splitting at the Route level for
 			// InferencePool backends, so if there's more than one backendRef, and one of them
 			// is an InferencePool, we mark the rule as invalid.
@@ -239,7 +239,8 @@ func processHTTPRouteRule(
 
 			svcName := controller.CreateInferencePoolServiceName(string(b.Name))
 			rbr = RouteBackendRef{
-				IsInferencePool: true,
+				IsInferencePool:   true,
+				InferencePoolName: key.Name,
 				BackendRef: v1.BackendRef{
 					BackendObjectReference: v1.BackendObjectReference{
 						Group:     helpers.GetPointer[v1.Group](""),
@@ -346,12 +347,12 @@ func processHTTPRouteRules(
 }
 
 // inferencePoolBackend returns if a Route references an InferencePool backend
-// and that InferencePool exists.
+// and that InferencePool exists. Also returns the NamespacedName of the InferencePool.
 func inferencePoolBackend(
 	backendRef v1.HTTPBackendRef,
 	routeNamespace string,
 	inferencePools map[types.NamespacedName]*inference.InferencePool,
-) bool {
+) (bool, types.NamespacedName) {
 	if backendRef.Group != nil &&
 		*backendRef.Group == inferenceAPIGroup &&
 		*backendRef.Kind == kinds.InferencePool {
@@ -364,11 +365,11 @@ func inferencePoolBackend(
 			Namespace: namespace,
 		}
 		if _, exists := inferencePools[key]; exists {
-			return true
+			return true, key
 		}
 	}
 
-	return false
+	return false, types.NamespacedName{}
 }
 
 func validateMatch(
diff --git a/internal/controller/state/graph/httproute_test.go b/internal/controller/state/graph/httproute_test.go
@@ -1038,7 +1038,8 @@ func TestBuildHTTPRoute(t *testing.T) {
 							Matches: hrInferencePool.Spec.Rules[0].Matches,
 							RouteBackendRefs: []RouteBackendRef{
 								{
-									IsInferencePool: true,
+									IsInferencePool:   true,
+									InferencePoolName: "ipool",
 									BackendRef: gatewayv1.BackendRef{
 										BackendObjectReference: gatewayv1.BackendObjectReference{
 											Group:     helpers.GetPointer[gatewayv1.Group](""),
diff --git a/internal/controller/state/graph/inferencepools.go b/internal/controller/state/graph/inferencepools.go
@@ -10,7 +10,6 @@ import (
 	apiv1 "sigs.k8s.io/gateway-api/apis/v1"
 
 	"github.com/nginx/nginx-gateway-fabric/v2/internal/controller/state/conditions"
-	"github.com/nginx/nginx-gateway-fabric/v2/internal/framework/controller"
 	"github.com/nginx/nginx-gateway-fabric/v2/internal/framework/kinds"
 )
 
@@ -101,7 +100,7 @@ func processInferencePoolsForGateway(
 				}
 
 				poolName := types.NamespacedName{
-					Name:      controller.GetInferencePoolName(string(ref.Name)),
+					Name:      ref.InferencePoolName,
 					Namespace: namespace,
 				}
 
diff --git a/internal/controller/state/graph/inferencepools_test.go b/internal/controller/state/graph/inferencepools_test.go
diff --git a/internal/controller/state/graph/route_common.go b/internal/controller/state/graph/route_common.go
diff --git a/internal/framework/controller/resource.go b/internal/framework/controller/resource.go
diff --git a/internal/framework/controller/resource_test.go b/internal/framework/controller/resource_test.go
diff --git a/renovate.json b/renovate.json
diff --git a/tests/go.mod b/tests/go.mod
diff --git a/tests/go.sum b/tests/go.sum

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ import (`
`12`	`12`	`)`
`13`	`13`
`14`	`14`	`const (`
`15`		`- // Regex from: https://github.com/kubernetes-sigs/gateway-api/blob/v1.4.0/apis/v1/shared_types.go#L675`
	`15`	`+ // Regex from: https://github.com/kubernetes-sigs/gateway-api/blob/v1.4.1/apis/v1/shared_types.go#L675`
`16`	`16`	controllerNameRegex = `^[a-z0-9]([-a-z0-9][a-z0-9])?(\.[a-z0-9]([-a-z0-9][a-z0-9])?)\/[A-Za-z0-9\/\-._~%!$&'()+,;=:]+$` //nolint:lll
`17`	`17`	`)`
`18`	`18`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-# Enhancement Proposal-4052: Authentiation Filter`
	`1`	`+# Enhancement Proposal-4052: Authentication Filter`
`2`	`2`
`3`	`3`	`- Issue: https://github.com/nginx/nginx-gateway-fabric/issues/4052`
`4`	`4`	`- Status: Implementable`