Skip to content

Conversation

xeioex
Copy link
Contributor

@xeioex xeioex commented Jan 9, 2025

This partially addresses #107.

Copy link
Member

@bavshin-f5 bavshin-f5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not convinced the commands initialization change is right. It assumes constness where we shouldn't, and could be less readable with a larger set of commands.

Copy link
Member

@bavshin-f5 bavshin-f5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ngx_module_t::default and CONF_OFFSET changes look good. I'm ready to cherry-pick these to master if you split the CONF_OFFSET patch and reorder both before the prelude one,

I have reservations about the prelude patch though. Maybe we need more high-level wrappers before introducing this.

Note: refactor!: prefix to the commit summaries seems more fitting. See https://www.conventionalcommits.org/en/v1.0.0/#summary and https://github.com/angular/angular/blob/22b96b9/CONTRIBUTING.md#-commit-message-guidelines

@bavshin-f5
Copy link
Member

Pushed e834149 and 4ee19c0 to master with minor adjustments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants