Inline optimizations.

Performance (bench4.js) for reference:

   after this patch:
      Richards: 686
      Crypto: 1028
      Splay: 2023
      NavierStokes: 1652
      ----
      Score (version 7): 1239

Author: VadimZhestikov

src/njs_atom.c

@@ -131,117 +131,3 @@ njs_atom_hash_init(njs_vm_t *vm)
 
     return NJS_OK;
 };
-
-
-/*
- * value is always key: string or number or symbol.
- *
- * symbol always contians atom_id by construction. do nothing;
- * number if short number it is atomized by "| 0x80000000";
- * string if represents short number it is atomized by "| 0x80000000";
- *
- * for string and symbol atom_ids common range is uint32_t < 0x80000000.
- */
-
-njs_int_t
-njs_atom_atomize_key(njs_vm_t *vm, njs_value_t *value)
-{
-    double             num;
-    uint32_t           hash_id;
-    njs_int_t          ret;
-    njs_value_t        val_str;
-    const njs_value_t  *entry;
-
-    switch (value->type) {
-    case NJS_STRING:
-        num = njs_key_to_index(value);
-        if (njs_fast_path(njs_key_is_integer_index(num, value)) &&
-            ((uint32_t) num) < 0x80000000)
-        {
-            value->atom_id = ((uint32_t) num) | 0x80000000;
-
-        } else {
-            hash_id = njs_djb_hash(value->string.data->start,
-                                   value->string.data->size);
-
-            entry = njs_lexer_keyword_find(vm, value->string.data->start,
-                                           value->string.data->size,
-                                           value->string.data->length,
-                                           hash_id);
-            if (njs_slow_path(entry == NULL)) {
-                return NJS_ERROR;
-            }
-
-            /* TODO: if (<<value is string>>) <<try release>>(string) */
-            *value = *entry;
-        }
-        break;
-
-    case NJS_NUMBER:
-        num = value->data.u.number;
-        if (njs_fast_path(njs_key_is_integer_index(num, value)) &&
-            ((uint32_t) num) < 0x80000000)
-        {
-            value->atom_id = ((uint32_t) num) | 0x80000000;
-
-        } else {
-            /* convert num to string, and atomize it. */
-            ret = njs_number_to_string(vm, &val_str, value);
-            if (ret != NJS_OK) {
-                return ret;
-            }
-
-            if (val_str.atom_id == 0) {
-                hash_id = njs_djb_hash(val_str.string.data->start,
-                                       val_str.string.data->size);
-
-                entry = njs_lexer_keyword_find(vm, val_str.string.data->start,
-                                               val_str.string.data->size,
-                                               val_str.string.data->length,
-                                               hash_id);
-                if (njs_slow_path(entry == NULL)) {
-                    return NJS_ERROR;
-                }
-
-                value->atom_id = entry->atom_id;
-
-            } else {
-                value->atom_id = val_str.atom_id;
-            }
-        }
-        break;
-    default:
-        /* NJS_SYMBOL: do nothing. */
-    }
-
-    return NJS_OK;
-}
-
-
-njs_int_t
-njs_atom_atomize_key_s(njs_vm_t *vm, njs_value_t *value)
-{
-    njs_int_t            ret;
-    njs_flathsh_query_t  lhq;
-
-    lhq.replace = 0;
-    lhq.proto = &njs_lexer_hash_proto;
-    lhq.pool = vm->atom_hash_mem_pool;
-
-
-    value->string.atom_id = (*vm->atom_hash_atom_id)++;
-
-    if (value->type == NJS_SYMBOL) {
-        lhq.key_hash = value->string.atom_id;
-
-        lhq.value = (void *) value;
-
-        ret = njs_flathsh_insert(vm->atom_hash, &lhq);
-        if (njs_slow_path(ret != NJS_OK)) {
-            njs_internal_error(vm, "flathsh insert/replace failed");
-            return NJS_ERROR;
-        }
-    }
-
-    return NJS_OK;
-}

src/njs_atom.h

@@ -45,8 +45,6 @@ enum {
 #include <njs_atom_map.h>
 
 njs_int_t njs_atom_hash_init(njs_vm_t *vm);
-njs_int_t njs_atom_atomize_key(njs_vm_t *vm, njs_value_t *value);
-njs_int_t njs_atom_atomize_key_s(njs_vm_t *vm, njs_value_t *value);
 
 extern const njs_atom_values_t    njs_atom;
 extern const njs_flathsh_proto_t  njs_atom_hash_proto;

src/njs_flathsh.c

@@ -78,7 +78,7 @@
 
 static njs_flathsh_descr_t *njs_flathsh_alloc(njs_flathsh_query_t *fhq,
     size_t hash_size, size_t elts_size);
-static njs_flathsh_descr_t *njs_expand_elts(njs_flathsh_query_t *fhq,
+njs_flathsh_descr_t *njs_expand_elts(njs_flathsh_query_t *fhq,
     njs_flathsh_descr_t *h);
 
 
@@ -122,13 +122,6 @@ njs_flathsh_descr(void *chunk, size_t hash_size)
 }
 
 
-njs_inline uint32_t *
-njs_hash_cells_end(njs_flathsh_descr_t *h)
-{
-    return (uint32_t *) h;
-}
-
-
 njs_inline void *
 njs_flathsh_chunk(njs_flathsh_descr_t *h)
 {
@@ -221,7 +214,7 @@ njs_flathsh_add_elt(njs_flathsh_t *fh, njs_flathsh_query_t *fhq)
 }
 
 
-static njs_flathsh_descr_t *
+njs_flathsh_descr_t *
 njs_expand_elts(njs_flathsh_query_t *fhq, njs_flathsh_descr_t *h)
 {
     void                 *chunk;

src/njs_flathsh.h

@@ -29,14 +29,6 @@ typedef void (*njs_flathsh_free_t)(void *ctx, void *p, size_t size);
 typedef struct njs_flathsh_proto_s  njs_flathsh_proto_t;
 
 
-struct njs_flathsh_proto_s {
-    uint32_t                   not_used;
-    njs_flathsh_test_t         test;
-    njs_flathsh_alloc_t        alloc;
-    njs_flathsh_free_t         free;
-};
-
-
 struct njs_flathsh_descr_s {
     uint32_t     hash_mask;
     uint32_t     elts_size;          /* allocated properties */
@@ -45,6 +37,14 @@ struct njs_flathsh_descr_s {
 };
 
 
+struct njs_flathsh_proto_s {
+    uint32_t                   not_used;
+    njs_flathsh_test_t         test;
+    njs_flathsh_alloc_t        alloc;
+    njs_flathsh_free_t         free;
+};
+
+
 struct njs_flathsh_query_s {
     uint32_t                   key_hash;
     njs_str_t                  key;
@@ -79,6 +79,13 @@ njs_hash_elts(njs_flathsh_descr_t *h)
 }
 
 
+njs_inline uint32_t *
+njs_hash_cells_end(njs_flathsh_descr_t *h)
+{
+    return (uint32_t *) h;
+}
+
+
 /*
  * njs_flathsh_find() finds a hash element.  If the element has been
  * found then it is stored in the fhq->value and njs_flathsh_find()
@@ -143,6 +150,8 @@ NJS_EXPORT njs_flathsh_elt_t *njs_flathsh_add_elt(njs_flathsh_t *fh,
 
 NJS_EXPORT njs_flathsh_descr_t *njs_flathsh_new(njs_flathsh_query_t *fhq);
 NJS_EXPORT void njs_flathsh_destroy(njs_flathsh_t *fh, njs_flathsh_query_t *fhq);
+NJS_EXPORT njs_flathsh_descr_t * njs_expand_elts(njs_flathsh_query_t *fhq,
+    njs_flathsh_descr_t *h);
 
 NJS_EXPORT njs_int_t njs_flathsh_alloc_copy(njs_mp_t *mp, njs_flathsh_t *to,
     njs_flathsh_t *from);