Skip to content

Commit 44e6c14

Browse files
authoredJan 29, 2023
Replace non-existent GitHub actions key (#238)
1 parent 3e4f941 commit 44e6c14

File tree

8 files changed

+30
-35
lines changed

8 files changed

+30
-35
lines changed
 

‎.github/CODEOWNERS

-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
# Main global owner #
22
#####################
3-
43
* @alessfg @aknot242
54
/.github/workflows/
65
*.md

‎.github/workflows/galaxy.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
name: Ansible Galaxy import
3-
"on":
3+
on:
44
release:
55
types:
66
- published

‎.github/workflows/molecule.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
---
22
name: Molecule CI/CD
3-
"on":
3+
on:
44
pull_request:
55
branches:
66
- main
77
push:
88
branches:
99
- main
10-
ignore-tags:
11-
- "*"
10+
tags-ignore:
11+
- "**"
1212
schedule:
1313
- cron: "0 0 1 * *"
1414
workflow_dispatch:

‎.github/workflows/release-drafter.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
name: Release Drafter
3-
"on":
3+
on:
44
pull_request:
55
types:
66
- opened

‎CHANGELOG.md

+6-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Changelog
22

3-
## 0.8.2 (Unreleased)
3+
## 0.9.0 (Unreleased)
44

55
FEATURES:
66

@@ -14,11 +14,14 @@ FEATURES:
1414

1515
ENHANCEMENTS:
1616

17-
Bump the Ansible `community.general` collection to `6.2.0`, `community.crypto` collection to `2.10.0` and `community.docker` collection to `3.4.0`.
17+
* Standardize code from dot to array notation to keep in with the standards set by the other roles in the Ansible NGINX core collection.
18+
* Bump the minimum version of Ansible core required to run the role to `2.12` (`2.11` is no longer supported by Ansible).
19+
* Bump the Ansible `community.general` collection to `6.2.0`, `community.crypto` collection to `2.10.0` and `community.docker` collection to `3.4.0`.
1820

1921
BUG FIXES:
2022

21-
The Alpine Linux `libelf` dependency is no longer automatically installed by NGINX App Protect DoS so we need to explicitly install it as a prerequisite.
23+
* The Alpine Linux `libelf` dependency is no longer automatically installed by NGINX App Protect DoS so we need to explicitly install it as a prerequisite.
24+
* The `ignore-tags` GitHub actions key does not exist. Replace it with the correct key, `tags-ignore`.
2225

2326
TESTS:
2427

‎README.md

+7-7
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ If you wish to install NGINX App Protect WAF or NGINX App Protect DoS using this
2020

2121
### Ansible
2222

23-
* This role is developed and tested with [maintained](https://docs.ansible.com/ansible/devel/reference_appendices/release_and_maintenance.html) versions of Ansible core (above `2.11`).
23+
* This role is developed and tested with [maintained](https://docs.ansible.com/ansible/devel/reference_appendices/release_and_maintenance.html) versions of Ansible core (above `2.12`).
2424
* When using Ansible core, you will also need to install the following collections:
2525

2626
```yaml
@@ -50,13 +50,13 @@ If you wish to install NGINX App Protect WAF or NGINX App Protect DoS using this
5050
* Instructions on how to install Molecule can be found in the [Molecule website](https://molecule.readthedocs.io/en/latest/installation.html). *You will also need to install the Molecule Docker driver.*
5151
* To run the Molecule tests, you must copy your NGINX App Protect license to the role's [`files/license`](https://github.com/nginxinc/ansible-role-nginx-app-protect/blob/main/files/license/) folder.
5252

53-
You can alternatively add your NGINX App Protect repository certificate and key to the local environment. Run the following commands to export these files as base64-encoded variables and execute the Molecule tests:
53+
You can alternatively add your NGINX App Protect repository certificate and key to the local environment. Run the following commands to export these files as base64-encoded variables and execute the Molecule tests:
5454

55-
```bash
56-
export NGINX_CRT=$( cat <path to your certificate file> | base64 )
57-
export NGINX_KEY=$( cat <path to your key file> | base64 )
58-
molecule test
59-
```
55+
```bash
56+
export NGINX_CRT=$( cat <path to your certificate file> | base64 )
57+
export NGINX_KEY=$( cat <path to your key file> | base64 )
58+
molecule test
59+
```
6060

6161
## Installation
6262

‎handlers/main.yml

+5-5
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@
2222

2323
- name: (Handler - NGINX App Protect) Print NGINX error if syntax check fails
2424
ansible.builtin.debug:
25-
var: config_check.stderr_lines
26-
failed_when: config_check.rc != 0
25+
var: config_check['stderr_lines']
26+
failed_when: config_check['rc'] != 0
2727
when:
28-
- config_check.stderr_lines is defined
29-
- config_check.stderr_lines != []
30-
- config_check.rc != 0
28+
- config_check['stderr_lines'] is defined
29+
- config_check['stderr_lines'] != []
30+
- config_check['rc'] != 0
3131
listen: (Handler - NGINX App Protect) Run NGINX

‎meta/main.yml

+7-14
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,25 @@
11
---
22
galaxy_info:
33
author: nginxinc
4-
description: Official Ansible role for NGINX App Protect WAF and DoS
4+
description: Official Ansible role for installing and configuring NGINX App Protect WAF and DoS
55
role_name: nginx_app_protect
66
company: F5, Inc.
77

88
license: Apache License, Version 2.0
99

10-
min_ansible_version: "2.11"
10+
min_ansible_version: '2.12'
1111

1212
platforms:
1313
- name: Alpine
14-
versions:
15-
- all
14+
versions: [all]
1615
- name: Amazon Linux 2
17-
versions:
18-
- all
16+
versions: [all]
1917
- name: EL
20-
versions:
21-
- "7"
22-
- "8"
18+
versions: ['7', '8']
2319
- name: Debian
24-
versions:
25-
- bullseye
20+
versions: [bullseye]
2621
- name: Ubuntu
27-
versions:
28-
- bionic
29-
- focal
22+
versions: [bionic, focal]
3023

3124
galaxy_tags:
3225
- waf

0 commit comments

Comments
 (0)
Please sign in to comment.