Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remane the Master Node label to node-role.kubernetes.io/control-plane #187

Open
teamc-tommy opened this issue Jan 15, 2025 · 0 comments
Open

Comments

@teamc-tommy
Copy link

Describe the bug

Since the K8S 1.24+, the label "node-role.kubernetes.io/master" is removed.
The NLK watch still using the deprecated label for checking the control-plane

To reproduce

Steps to reproduce the behavior:

  1. Deploy nginx_loadbalancer_kubernetes
  2. The Master Node (control plane) node is listed in the HTTP upstream
  3. Only worker should be in the upstream list

Expected behavior

The NLK watcher should use the control plane label. "node-role.kubernetes.io/control-plane"

Your environment

Kubernetes 1.31.1
nginx_loadbalancer_kubernetes 178

Additional context

Source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant