Skip to content

Usability "upgrades" #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sodapopcan wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Usability "upgrades" #14

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2037d2b
Do not open QF window when there are no violations
sodapopcan Oct 22, 2015
ee03711
Be less noisy when auto-correcting
sodapopcan Oct 23, 2015
e051b3e
Refuse to run if buffer is modified
sodapopcan Oct 23, 2015
38b5dfb
Only define RuboCop command for ruby buffers
sodapopcan Oct 23, 2015
e16337e
Add -D/--display-cop-names flags to completion list
sodapopcan Oct 23, 2015
e1bc6ac
Silence edit command
sodapopcan Oct 23, 2015
0603560
Only define QF mappings if QF window is open
sodapopcan Oct 23, 2015
988b605
Open qf window botright
sodapopcan Nov 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions plugin/rubocop.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,12 @@ function! s:RuboCop(current_args)
endif
let l:rubocop_output = substitute(l:rubocop_output, '\\"', "'", 'g')
let l:rubocop_results = split(l:rubocop_output, "\n")
cexpr l:rubocop_results
copen
if len(l:rubocop_results)
Copy link

@hawkins hawkins Nov 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think cwindow in essence does this same logic; if there are errors populated in cexpr, then it opens the cwindow if it is not opened. Else, it does nothing

Copy link
Author

@sodapopcan sodapopcan Nov 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, I forgot all about this PR and have been just maintaining my own fork.

cwindow doesn't work here since it's just parsing the return value of a system() call which does not populate the quickfix list.

cexpr l:rubocop_results
copen
else
echo 'RuboCop: No violations!'
endif
" Shortcuts taken from Ack.vim - git://github.com/mileszs/ack.vim.git
exec "nnoremap <silent> <buffer> q :ccl<CR>"
exec "nnoremap <silent> <buffer> t <C-W><CR><C-W>T"
Expand Down