Skip to content

Commit 0658d7f

Browse files
authored
Merge pull request #37 from nguyenanhung/develop
Optimize Code Performance
2 parents 5e0a541 + 44c24e6 commit 0658d7f

16 files changed

Lines changed: 36 additions & 94 deletions

helpers/assets_helper.php

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,9 @@ function assets_url($uri = '', $protocol = null)
2828
if ($fileExt === 'CSS' || $fileExt === 'JS') {
2929
$version = config_item('assets_version');
3030
}
31-
3231
return trim(base_url('assets/' . $uri, $protocol) . $version);
3332
}
34-
3533
return trim($uri);
36-
3734
}
3835
}
3936
if (!function_exists('static_url')) {
@@ -57,12 +54,9 @@ function static_url($uri = '')
5754
$version = config_item('assets_version');
5855
}
5956
$host = config_item('static_url');
60-
6157
return trim($host) . trim($uri) . trim($version);
6258
}
63-
6459
return trim($uri);
65-
6660
}
6761
}
6862
if (!function_exists('templates_url')) {
@@ -86,10 +80,8 @@ function templates_url($uri = '', $protocol = null)
8680
if ($fileExt === 'CSS' || $fileExt === 'JS') {
8781
$version = config_item('assets_version');
8882
}
89-
9083
return trim(base_url('templates/' . $uri, $protocol) . $version);
9184
}
92-
9385
return trim($uri);
9486
}
9587
}
@@ -108,7 +100,6 @@ function templates_url($uri = '', $protocol = null)
108100
function editor_url($uri = '', $protocol = null)
109101
{
110102
$uri = 'editors/' . $uri;
111-
112103
return assets_url($uri, $protocol);
113104
}
114105
}
@@ -127,7 +118,6 @@ function editor_url($uri = '', $protocol = null)
127118
function favicon_url($uri = '', $protocol = null)
128119
{
129120
$uri = 'favicon/' . $uri;
130-
131121
return assets_url($uri, $protocol);
132122
}
133123
}
@@ -146,7 +136,6 @@ function favicon_url($uri = '', $protocol = null)
146136
function fav_url($uri = '', $protocol = null)
147137
{
148138
$uri = 'fav/' . $uri;
149-
150139
return assets_url($uri, $protocol);
151140
}
152141
}
@@ -187,10 +176,8 @@ function storage_url($uri = '')
187176
$version = config_item('assets_version');
188177
}
189178
$storageUrl = trim(config_item('storage_url')) . trim($uri) . $version;
190-
191179
return trim($storageUrl);
192180
}
193-
194181
return $uri;
195182
}
196183
}
@@ -215,12 +202,9 @@ function public_storage_tmp_url($uri = '', $protocol = null)
215202
if ($fileExt === 'CSS' || $fileExt === 'JS') {
216203
$version = config_item('assets_version');
217204
}
218-
219205
return trim(base_url('storage/tmp/' . $uri, $protocol) . $version);
220206
}
221-
222207
return trim($uri);
223-
224208
}
225209
}
226210
if (!function_exists('go_url')) {
@@ -238,10 +222,8 @@ function go_url($uri = '')
238222
{
239223
if (function_exists('config_item')) {
240224
$goUrl = trim(config_item('go_url')) . trim($uri);
241-
242225
return trim($goUrl);
243226
}
244-
245227
return $uri;
246228
}
247229
}
@@ -260,7 +242,6 @@ function go_url($uri = '')
260242
function assets_mobile($uri = '', $protocol = null)
261243
{
262244
$uri = 'mobile/assets/' . $uri;
263-
264245
return assets_url($uri, $protocol);
265246
}
266247
}
@@ -294,7 +275,6 @@ function assets_themes($themes = '', $uri = '', $folder = 'yes', $protocol = nul
294275
} else {
295276
$uri = 'themes/assets/' . $uri;
296277
}
297-
298278
return assets_url($uri, $protocol);
299279
}
300280
}
@@ -386,7 +366,6 @@ function assets_themes_metronic($uri = '', $protocol = null)
386366
function cdn_js_url($uri = '')
387367
{
388368
$cdnJs = '//cdnjs.cloudflare.com/ajax/libs/';
389-
390369
return $cdnJs . trim($uri);
391370
}
392371
}
@@ -404,7 +383,6 @@ function cdn_js_url($uri = '')
404383
function google_fonts_url($family = '')
405384
{
406385
$fonts = '//fonts.googleapis.com/css?family=';
407-
408386
return $fonts . trim($family);
409387
}
410388
}
@@ -422,7 +400,6 @@ function google_fonts_url($family = '')
422400
function bootstrapcdn_url($uri = '')
423401
{
424402
$cdn = '//maxcdn.bootstrapcdn.com/bootstrap/';
425-
426403
return $cdn . trim($uri);
427404
}
428405
}

helpers/common_helper.php

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -61,20 +61,14 @@ function isEmpty($input = '')
6161
if ($input === null || $input === false || $input === '') {
6262
return true;
6363
}
64-
6564
$isset = isset($input);
66-
6765
if ($isset === true) {
68-
6966
$empty = empty($input);
70-
7167
if ($empty) {
7268
return true;
7369
}
74-
7570
return false;
7671
}
77-
7872
return true;
7973
}
8074
}
@@ -101,7 +95,6 @@ function defaultCompressHtmlOutput($html = '')
10195
'/(\s)+/s' // shorten multiple whitespace sequences
10296
);
10397
$replace = array(' ', '>', '<', '\\1');
104-
10598
return preg_replace($search, $replace, $html);
10699
}
107100
}
@@ -110,7 +103,6 @@ function generateRandomUniqueId()
110103
{
111104
$uniqid = uniqid('-bear-', true);
112105
$uniqid = trim(str_replace('.', '', $uniqid));
113-
114106
return date('Ymd') . '-' . generate_uuid_v4() . $uniqid;
115107
}
116108
}
@@ -119,7 +111,6 @@ function generateRandomNanoUniqueId()
119111
{
120112
$uniqid = uniqid('-bear-', true);
121113
$uniqid = trim(str_replace('.', '', $uniqid));
122-
123114
return date('Ymd') . '-' . randomNanoId(16) . $uniqid;
124115
}
125116
}

helpers/database_helper.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,9 @@ function generate_list_id_with_parent_id($allSubId, $parentId, $field = 'id')
3535
$itemId = is_array($item) ? $item[$field] : $item->$field;
3636
$listSub[] = $itemId; // Push các category con vào mảng dữ liệu
3737
}
38-
3938
return $listSub;
4039
}
4140
}
42-
4341
return $parentId;
4442
}
4543

helpers/date_helper.php

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,7 @@ function dayFloor($beginTime = '', $endTime = '')
2424
if (empty($beginTime) && empty($endTime)) {
2525
return 0;
2626
}
27-
2827
$floor = abs(strtotime($beginTime) - strtotime($endTime));
29-
3028
return (int) floor($floor / (60 * 60 * 24));
3129
}
3230
}
@@ -47,7 +45,6 @@ function getZuluTime()
4745
if (function_exists('log_message')) {
4846
log_message('error', __get_error_message__($e));
4947
}
50-
5148
return null;
5249
}
5350
}
@@ -82,7 +79,6 @@ function smart_bear_date_range($first, $last, $step = '+1 day', $format = 'Y-m-d
8279
$dates[] = date($format, $current);
8380
$current = strtotime($step, $current);
8481
}
85-
8682
return $dates;
8783
}
8884
}
@@ -100,7 +96,6 @@ function format_datetime_vn($datetime = '', $type = 'datetime')
10096
} else {
10197
$timestamp = strtotime($datetime);
10298
}
103-
10499
return date('d-m-Y H:i:s', $timestamp);
105100
}
106101
}
@@ -124,7 +119,6 @@ function get_start_and_end_date_for_week($week, $year)
124119
$return[0] = date('d-m-Y', $time);
125120
$time += 6 * 24 * 3600;
126121
$return[1] = date('d-m-Y', $time);
127-
128122
return $return;
129123
}
130124
}

helpers/escape_helper.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ function bear_framework_basic_clean_str($str = '')
1616
$str = trim($str);
1717
$str = strip_tags($str);
1818
$str = htmlspecialchars($str, ENT_QUOTES | ENT_HTML5 | ENT_XHTML, 'UTF-8');
19-
2019
return trim($str);
2120
}
2221
}

helpers/facebook_helper.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@ function widget_facebook_script_init($appId = '', $version = 'v14.0')
9191
$version = 'v14.0';
9292
}
9393
$url = 'https://connect.facebook.net/vi_VN/sdk.js#xfbml=1&version=' . trim($version) . '&appId=' . trim($appId) . '&autoLogAppEvents=1';
94-
9594
return '<div id="fb-root"></div><script async defer crossorigin="anonymous" src="' . trim($url) . '" nonce="EOLK7Cbn"></script>';
9695
}
9796
}

helpers/image_helper.php

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -99,16 +99,14 @@ function bear_framework_image_url($input = '', $server = '', $base = 'live')
9999
if (in_array($images_url, $no_thumb)) {
100100
return assets_url($images_url);
101101
}
102-
103-
$parse_input = parse_url($images_url);
104-
if (isset($parse_input['host'])) {
102+
$parse = parse_url($images_url);
103+
if (isset($parse['host'])) {
105104
return $images_url;
106105
}
107106
if (trim(mb_substr($images_url, 0, 12)) === 'crawler-news') {
108107
$images_url = trim('uploads/' . $images_url);
109108
}
110109
$images_url = str_replace(array('upload-vcms/news/news/', 'upload-vcms/mheath/mheath/'), array('upload-vcms/news/', 'upload-vcms/mheath/'), $images_url);
111-
112110
return config_item('static_url') . $images_url;
113111
}
114112

@@ -151,7 +149,7 @@ function create_image_thumbnail($url = '', $width = 100, $height = 100)
151149
return nguyenanhung\CodeIgniter\BasicHelper\ImageHelper::createThumbnail($url, $width, $height);
152150
}
153151
}
154-
if (!function_exists('create_image_thumbnail')) {
152+
if (!function_exists('bear_framework_create_image_thumbnail_with_cache')) {
155153
/**
156154
* Function bear_framework_create_image_thumbnail_with_cache
157155
*

helpers/nanoid_helper.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,8 @@ function randomNanoId($size = 21, $prefix = 'Bear-')
2323
{
2424
if (class_exists('Hidehalo\Nanoid\Client')) {
2525
$client = new Hidehalo\Nanoid\Client();
26-
2726
return $client->generateId($size);
2827
}
29-
3028
return uniqid($prefix, true);
3129
}
3230
}

helpers/number_helper.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,3 +87,9 @@ function convertNumberToWords($num)
8787
return $returnTxt;
8888
}
8989
}
90+
if (!function_exists('convert_number_to_words')) {
91+
function convert_number_to_words($num)
92+
{
93+
return convertNumberToWords($num);
94+
}
95+
}

helpers/paging_helper.php

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ function view_paginations($page_type, $total_item, $item_per_page, $current_page
3333
$page_prefix = '&page=';
3434
$page_suffix = '';
3535
}
36-
3736
$data = array(
3837
'page_type' => $page_type,
3938
'page_link' => $page_link,
@@ -57,7 +56,6 @@ function view_paginations($page_type, $total_item, $item_per_page, $current_page
5756
);
5857
$pagination = new \nguyenanhung\Libraries\Pagination\Pagination\SimplePagination();
5958
$pagination->setData($data);
60-
6159
return $pagination->build();
6260
}
6361
}
@@ -100,7 +98,6 @@ function view_more($page_number, $page_total, $page_size, $url = '', $title = ''
10098
);
10199
$pagination = new \nguyenanhung\Libraries\Pagination\Pagination\SimplePagination();
102100
$pagination->setData($data);
103-
104101
return $pagination->buildViewMore();
105102
}
106103
}
@@ -149,7 +146,6 @@ function select_page($total_rows, $per_page, $page_number, $type = '', $page_lin
149146
);
150147
$pagination = new \nguyenanhung\Libraries\Pagination\Pagination\SimplePagination();
151148
$pagination->setData($data);
152-
153149
return $pagination->buildSelectPage();
154150
}
155151
}
@@ -167,7 +163,6 @@ function select_page($total_rows, $per_page, $page_number, $type = '', $page_lin
167163
function get_paginations_title($str)
168164
{
169165
$pagination = new \nguyenanhung\Libraries\Pagination\Pagination\SimplePagination();
170-
171166
return $pagination->getPaginationsTitle($str);
172167
}
173168
}
@@ -185,7 +180,6 @@ function get_paginations_title($str)
185180
function get_paginations_number($str)
186181
{
187182
$pagination = new \nguyenanhung\Libraries\Pagination\Pagination\SimplePagination();
188-
189183
return $pagination->getPageNumber($str);
190184
}
191185
}
@@ -204,7 +198,6 @@ function bear_framework_news_view_pagination($data = array())
204198
{
205199
$pagination = new \nguyenanhung\Libraries\Pagination\Pagination\SimplePagination();
206200
$pagination->setData($data);
207-
208201
return $pagination->build();
209202
}
210203
}

0 commit comments

Comments
 (0)