[TASK] Fix PHPStan errors

Author: nhovratov

Classes/Command/MaskToContentBlocksCommand.php

@@ -37,14 +37,17 @@ public function __construct(
         protected TableDefinitionCollection $tableDefinitionCollection,
         protected PreviewIconResolver $previewIconResolver,
         protected ContentBlockBuilder $contentBlockBuilder,
+        /**
+         * @var array{content?: string, backend?: string}
+         */
         protected array $maskExtensionConfiguration,
     ) {
         parent::__construct();
     }
 
     public function execute(InputInterface $input, OutputInterface $output): int
     {
-        $table = ContentType::CONTENT_ELEMENT->getTable();
+        $table = 'tt_content';
         $targetExtension = $this->extractExtensionFromMaskConfiguration();
         if (!$this->tableDefinitionCollection->hasTable($table)) {
             $output->writeln('No Mask elements found.');
@@ -55,7 +58,9 @@ public function execute(InputInterface $input, OutputInterface $output): int
             if ($element->hidden) {
                 continue;
             }
-            $fieldArray = $this->traverseMaskColumnsRecursive($element, $element->columns, $contentElementTableDefinition);
+            /** @var string[] $columns */
+            $columns = $element->columns;
+            $fieldArray = $this->traverseMaskColumnsRecursive($element, $columns, $contentElementTableDefinition);
             $contentBlockName = str_replace('_', '-', $element->key);
             $name = 'mask/' . $contentBlockName;
             $path = 'EXT:' . $targetExtension . '/' . ContentBlockPathUtility::getRelativeContentElementsPath();
@@ -102,7 +107,7 @@ protected function extractExtensionFromMaskConfiguration(): string
         return $extensionKey;
     }
 
-    protected function copyFrontendTemplate(string $contentElementKey, $targetExtPath): void
+    protected function copyFrontendTemplate(string $contentElementKey, string $targetExtPath): void
     {
         $absolutePath = GeneralUtility::getFileAbsFileName($targetExtPath);
         $absoluteTemplatePath = $absolutePath . '/' . ContentBlockPathUtility::getFrontendTemplatePath();
@@ -112,22 +117,23 @@ protected function copyFrontendTemplate(string $contentElementKey, $targetExtPat
         }
     }
 
-    protected function copyPreviewTemplate(string $contentElementKey, $targetExtPath): void
+    protected function copyPreviewTemplate(string $contentElementKey, string $targetExtPath): void
     {
         $absolutePath = GeneralUtility::getFileAbsFileName($targetExtPath);
         $absoluteTemplatePath = $absolutePath . '/' . ContentBlockPathUtility::getBackendPreviewPath();
+        $backendPreviewTemplatePath = (string)($this->maskExtensionConfiguration['backend'] ?? '');
         $maskPreviewTemplate = TemplatePathUtility::getTemplatePath(
             $this->maskExtensionConfiguration,
             $contentElementKey,
             false,
-            GeneralUtility::getFileAbsFileName($this->maskExtensionConfiguration['backend'] ?? '')
+            GeneralUtility::getFileAbsFileName($backendPreviewTemplatePath)
         );
         if (file_exists($maskPreviewTemplate)) {
             copy($maskPreviewTemplate, $absoluteTemplatePath);
         }
     }
 
-    protected function copyIcon(string $contentElementKey, $targetExtPath): void
+    protected function copyIcon(string $contentElementKey, string $targetExtPath): void
     {
         $absolutePath = GeneralUtility::getFileAbsFileName($targetExtPath);
         $absoluteIconPath = $absolutePath . '/' . ContentBlockPathUtility::getIconPathWithoutFileExtension();
@@ -144,12 +150,20 @@ protected function copyIcon(string $contentElementKey, $targetExtPath): void
         }
     }
 
+    /**
+     * @param string[] $columns
+     * @return array<array<string, mixed>>
+     */
     protected function traverseMaskColumnsRecursive(ElementDefinition $element, array $columns, TableDefinition $tableDefinition): array
     {
         $fieldArray = [];
+        if ($tableDefinition->tca === null) {
+            return $fieldArray;
+        }
         foreach ($columns as $fieldKey) {
             $field = [];
             $tcaFieldDefinition = $tableDefinition->tca->getField($fieldKey);
+            /** @var array<string, mixed> $tca */
             $tca = $tcaFieldDefinition->realTca['config'] ?? [];
             unset($tca['type']);
             try {
@@ -194,6 +208,7 @@ protected function traverseMaskColumnsRecursive(ElementDefinition $element, arra
             $columnsOverrides = [];
             if ($element->hasColumnsOverride($fieldKey)) {
                 $columnsOverrideTcaDefinition = $element->getColumnsOverride($fieldKey);
+                /** @var array<string, mixed> $columnsOverrides */
                 $columnsOverrides = $columnsOverrideTcaDefinition->realTca['config'] ?? [];
             }
             $field = array_merge($field, $tca, $columnsOverrides);
@@ -227,7 +242,9 @@ protected function traverseMaskColumnsRecursive(ElementDefinition $element, arra
             }
             if ($fieldType->isParentField()) {
                 $inlineFields = $this->tableDefinitionCollection->loadInlineFields($fieldKey, $element->key, $element);
-                $inlineColumns = array_map(fn (array $tcaField) => $tcaField['fullKey'], $inlineFields->toArray());
+                /** @var array<array{fullKey: string}> $array */
+                $array = $inlineFields->toArray();
+                $inlineColumns = array_map(fn (array $tcaField): string => $tcaField['fullKey'], $array);
                 $foreignTableDefinition = $tableDefinition;
                 if ($fieldType === FieldType::INLINE) {
                     unset($field['foreign_table']);

composer.json

@@ -36,6 +36,7 @@
     "require-dev": {
         "typo3/cms-install": "^13.4",
         "typo3/cms-rte-ckeditor": "^13.4",
-        "typo3/cms-lowlevel": "^13.4"
+        "typo3/cms-lowlevel": "^13.4",
+        "phpstan/phpstan": "^2.0"
     }
 }