Skip to content

Updating instrument parameter's gRPC Name and version to 26.0.0 for S…#1232

Merged
dheineke merged 1 commit intoreleases/2.14from
main
Dec 17, 2025
Merged

Updating instrument parameter's gRPC Name and version to 26.0.0 for S…#1232
dheineke merged 1 commit intoreleases/2.14from
main

Conversation

@dheineke
Copy link
Contributor

Merge from main

The purpose of this pull request is to merge change into the 2.14 release branch. It is a copy of pull request #1231 that was meant to go into 2.14 but was merged into main after the 2.14 branch was created. The below sections are the original description of the original pull request to merge to main:

What does this Pull Request accomplish?

Updates the instrument parameter's grpc-name by updating the gRPC Scrapigen Device Code for SpecAn Private DPD and IDPD APIs and its corresponding enums.

Why should this Pull Request be merged?

To updates the instrument parameter's grpc-name of the newly added Private SpecAn APIs to stay in consistent with the other APIs of the nirfmxspecan_restricted component and keep it up to date with the latest version i.e. 26.0.0

What testing has been done?

Manually inspected generated files.
Copied files from grpc-device-scrapigen/out/nirfmxspecan_restricted/export/ to grpc-device/source/codegen/metadata/nirfmxspecan_restricted/ and built grpc-device successfully.
Manually inspected nirfmxspecan_restricted.proto file.

@dheineke dheineke requested a review from ThangamV-NI December 16, 2025 21:57
@astarche astarche added the source-breaking Change to proto file that will break client if they update label Dec 16, 2025
@astarche
Copy link
Collaborator

@dheineke I marked this "source breaking" but please remove the tag if the original name never shipped.

@reckenro
Copy link
Collaborator

reckenro commented Dec 16, 2025

@dheineke I marked this "source breaking" but please remove the tag if the original name never shipped.

@astarche , this is a a restricted proto file. Do we mark source breaking for them?

In any case, I saw these were added 5 days ago here so not in the previous release. Removing "source breaking" tag.

@reckenro reckenro removed the source-breaking Change to proto file that will break client if they update label Dec 16, 2025
@dheineke dheineke merged commit 7976cc4 into releases/2.14 Dec 17, 2025
20 of 22 checks passed
@astarche
Copy link
Collaborator

@dheineke I marked this "source breaking" but please remove the tag if the original name never shipped.

@astarche , this is a a restricted proto file. Do we mark source breaking for them?

In any case, I saw these were added 5 days ago here so not in the previous release. Removing "source breaking" tag.

I guess either way is fine. Source breaking just gets summarized in the release notes right? I figured a decent proportion of our clients are internal any might want to know. But if source breaking sets off any other alarms, I'd agree it makes sense to exclude restricted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants