Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITs should not check for SHA1/MD5 #88

Open
kwin opened this issue Jun 9, 2020 · 1 comment
Open

ITs should not check for SHA1/MD5 #88

kwin opened this issue Jun 9, 2020 · 1 comment
Labels

Comments

@kwin
Copy link
Contributor

kwin commented Jun 9, 2020

Some ITs check for SHA1/MD5 being generated in the local repo. That is not a good test as those are being generated by maven-install-plugin prior to version 3.0.0-M1 (https://issues.apache.org/jira/browse/MINSTALL-143). You should either explicitly disable checksum creation via https://maven.apache.org/components/plugins-archives/maven-install-plugin-2.5.2/install-mojo.html#createChecksum or rely on other checksums in the IT!

Update: Even disabling the checksum creation does not work, as the maven-resolver-plugin will generate it anyways (compare with apache/maven-artifact-transfer#16).

@nicoulaj nicoulaj added the Bug label Dec 28, 2020
@nicoulaj
Copy link
Owner

Indeed (grep 'helper.assertFileIsNotEmptyInLocalRepo' **/postbuild.groovy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants