Skip to content

Commit 2a503c0

Browse files
authored
Merge pull request #170 from Chandan-DK/fix-chainsaw-tests
fix: update chainsaw tests violations messages
2 parents 1094f7f + dd1a443 commit 2a503c0

File tree

46 files changed

+135
-104
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

46 files changed

+135
-104
lines changed

dockerfile-best-practices/check-apt-command-force-yes/test/chainsaw-test.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ spec:
5353
name: check-apt-command-force-yes
5454
error: ~
5555
violations:
56-
- message: refrain from using the '--force-yes' option with `apt-get` as it bypasses important package validation checks and can potentially compromise the stability and security of your system.
56+
- message: refrain from using the '--force-yes' option with `apt-get` as it bypasses important package validation checks and can potentially compromise the stability and security of your system. (CHECK=spec.rules[0].assert.all[0])
5757
errors:
5858
- type: FieldValueInvalid
5959
value: true
@@ -87,7 +87,7 @@ spec:
8787
name: check-apt-command-force-yes
8888
error: ~
8989
violations:
90-
- message: refrain from using the '--force-yes' option with `apt` as it bypasses important package validation checks and can potentially compromise the stability and security of your system.
90+
- message: refrain from using the '--force-yes' option with `apt` as it bypasses important package validation checks and can potentially compromise the stability and security of your system. (CHECK=spec.rules[0].assert.all[1])
9191
errors:
9292
- type: FieldValueInvalid
9393
value: true

dockerfile-best-practices/check-authentication/test/chainsaw-test.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ spec:
5353
name: detect-unauthenticated-flag
5454
error: ~
5555
violations:
56-
- message: Dockerfile contains the '--allow-unauthenticated' which is not preferred
56+
- message: Dockerfile contains the '--allow-unauthenticated' which is not preferred (CHECK=spec.rules[0].assert.any[0])
5757
errors:
5858
- type: FieldValueInvalid
5959
value: true

dockerfile-best-practices/check-certificate-validation-curl/test/chainsaw-test.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ spec:
5353
name: check-certificate-validation-curl
5454
error: ~
5555
violations:
56-
- message: Ensure certificate validation is enabled by not using `--insecure` option
56+
- message: Ensure certificate validation is enabled by not using `--insecure` option (CHECK=spec.rules[0].assert.any[0])
5757
errors:
5858
- type: FieldValueInvalid
5959
value: true

dockerfile-best-practices/check-certificate-validation-nodejs-env-var/test/chainsaw-test.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ spec:
5353
name: check-certificate-validation-nodejs-env-var
5454
error: ~
5555
violations:
56-
- message: Ensure certificate validation is enabled by using `NODE_TLS_REJECT_UNAUTHORIZED` env with value set to `1`
56+
- message: Ensure certificate validation is enabled by using `NODE_TLS_REJECT_UNAUTHORIZED` env with value set to `1` (CHECK=spec.rules[0].assert.any[0])
5757
errors:
5858
- type: FieldValueInvalid
5959
value: false

dockerfile-best-practices/check-certificate-validation-pip3/test/chainsaw-test.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ spec:
5353
name: check-certificate-validation-pip3
5454
error: ~
5555
violations:
56-
- message: Ensure certificate validation is enabled by not using `--trusted-host` option with pip3
56+
- message: Ensure certificate validation is enabled by not using `--trusted-host` option with pip3 (CHECK=spec.rules[0].assert.all[1])
5757
errors:
5858
- type: FieldValueInvalid
5959
value: true
@@ -86,7 +86,7 @@ spec:
8686
name: check-certificate-validation-pip3
8787
error: ~
8888
violations:
89-
- message: Ensure certificate validation is enabled by not using `--trusted-host` option with pip
89+
- message: Ensure certificate validation is enabled by not using `--trusted-host` option with pip (CHECK=spec.rules[0].assert.all[0])
9090
errors:
9191
- type: FieldValueInvalid
9292
value: true

dockerfile-best-practices/check-certificate-validation-python-env-var/test/chainsaw-test.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ spec:
5353
name: check-certificate-validation-python-env-var
5454
error: ~
5555
violations:
56-
- message: Ensure certificate validation is enabled by using `PYTHONHTTPSVERIFY` env with value set to `1`
56+
- message: Ensure certificate validation is enabled by using `PYTHONHTTPSVERIFY` env with value set to `1` (CHECK=spec.rules[0].assert.any[0])
5757
errors:
5858
- type: FieldValueInvalid
5959
value: false

dockerfile-best-practices/check-certificate-validation-wget/test/chainsaw-test.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ spec:
5353
name: check-certificate-validation-wget
5454
error: ~
5555
violations:
56-
- message: Ensure certificate validation is enabled by not using `--no-check-certificate` option
56+
- message: Ensure certificate validation is enabled by not using `--no-check-certificate` option (CHECK=spec.rules[0].assert.any[0])
5757
errors:
5858
- type: FieldValueInvalid
5959
value: true

dockerfile-best-practices/check-missing-signature-options/test/chainsaw-test.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ spec:
5353
name: check-missing-signature-options
5454
error: ~
5555
violations:
56-
- message: Ensure that packages with untrusted or missing signatures are not used by rpm via `--nodigest` flag
56+
- message: Ensure that packages with untrusted or missing signatures are not used by rpm via `--nodigest` flag (CHECK=spec.rules[0].assert.all[3])
5757
errors:
5858
- type: FieldValueInvalid
5959
value: true
@@ -86,7 +86,7 @@ spec:
8686
name: check-missing-signature-options
8787
error: ~
8888
violations:
89-
- message: Ensure that packages with untrusted or missing signatures are not used by rpm via `--nosignature` flag
89+
- message: Ensure that packages with untrusted or missing signatures are not used by rpm via `--nosignature` flag (CHECK=spec.rules[0].assert.all[2])
9090
errors:
9191
- type: FieldValueInvalid
9292
value: true
@@ -119,7 +119,7 @@ spec:
119119
name: check-missing-signature-options
120120
error: ~
121121
violations:
122-
- message: Ensure that packages with untrusted or missing signatures are not used by rpm via `--noverify` flag
122+
- message: Ensure that packages with untrusted or missing signatures are not used by rpm via `--noverify` flag (CHECK=spec.rules[0].assert.all[1])
123123
errors:
124124
- type: FieldValueInvalid
125125
value: true
@@ -152,7 +152,7 @@ spec:
152152
name: check-missing-signature-options
153153
error: ~
154154
violations:
155-
- message: Ensure that packages with untrusted or missing signatures are not used by rpm via `--nofiledigest` flag
155+
- message: Ensure that packages with untrusted or missing signatures are not used by rpm via `--nofiledigest` flag (CHECK=spec.rules[0].assert.all[0])
156156
errors:
157157
- type: FieldValueInvalid
158158
value: true

dockerfile-best-practices/check-nogpgcheck/test/chainsaw-test.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ spec:
109109
name: check-nogpgcheck
110110
error: ~
111111
violations:
112-
- message: Enable GPG signature checking with yum by not using `--nogpgcheck` flag
112+
- message: Enable GPG signature checking with yum by not using `--nogpgcheck` flag (CHECK=spec.rules[0].assert.all[0])
113113
errors:
114114
- type: FieldValueInvalid
115115
value: true
@@ -142,7 +142,7 @@ spec:
142142
name: check-nogpgcheck
143143
error: ~
144144
violations:
145-
- message: Enable GPG signature checking with dnf by not using `--nogpgcheck` flag
145+
- message: Enable GPG signature checking with dnf by not using `--nogpgcheck` flag (CHECK=spec.rules[0].assert.all[1])
146146
errors:
147147
- type: FieldValueInvalid
148148
value: true
@@ -175,7 +175,7 @@ spec:
175175
name: check-nogpgcheck
176176
error: ~
177177
violations:
178-
- message: Enable GPG signature checking with tdnf by not using `--nogpgcheck` flag
178+
- message: Enable GPG signature checking with tdnf by not using `--nogpgcheck` flag (CHECK=spec.rules[0].assert.all[2])
179179
errors:
180180
- type: FieldValueInvalid
181181
value: true

dockerfile-best-practices/check-npm-config-strict-ssl/test/chainsaw-test.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ spec:
5353
name: check-npm-config-strict-ssl
5454
error: ~
5555
violations:
56-
- message: Ensure certificate validation is enabled by setting `NODE_TLS_REJECT_UNAUTHORIZED` env with value set to `true`
56+
- message: Ensure certificate validation is enabled by setting `NODE_TLS_REJECT_UNAUTHORIZED` env with value set to `true` (CHECK=spec.rules[0].assert.any[0])
5757
errors:
5858
- type: FieldValueInvalid
5959
value: false

0 commit comments

Comments
 (0)