Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about the Logger #221

Open
thomasms opened this issue Jan 24, 2025 · 2 comments
Open

Question about the Logger #221

thomasms opened this issue Jan 24, 2025 · 2 comments

Comments

@thomasms
Copy link

Hello,

This is more of a question than an issue, but I thought it was worth raising here in case someone else has a similar question.

Regarding the logger, when using ENDFtk via the python bindings is there any way to configure the logger without having to recompile?

Can I change the log level or the sink, via an API for example?
I can't see anything in the tools library that exposes this but I am not sure where I should be looking for such functionality.

@thomasms
Copy link
Author

I have a rough PR to make this work, basically adding a new log submodule and adding a basic set/get_level, but because it also requires additional changes to the tools lib in the Log.hpp I was not sure how best to tackle this.

Do I first open a PR on the tools repo to expose more public methods and then here?

Or, more importantly, do you even want the log being exposed at all?

@whaeck
Copy link
Member

whaeck commented Jan 27, 2025

To be honest, I do not know. This logger is going to give us headaches at some point. I have seen exceptions being raised when using ENDFtk and ACEtk in python and both wanting to log things. At some point we will have to overhaul this thing, but as usual it is not high priority. We continue to use it because that's what's there.

The fact that messages get printed to stdout (I think) is annoying, as I would prefer an actual log file I can go through - or even switch it off entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants