Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from CppHeaderParser to cxxheaderparser (available as a system package). #50

Open
powderluv opened this issue Feb 1, 2025 · 3 comments

Comments

@powderluv
Copy link
Contributor

Can we also update clr/hipamd/src/hip_prof_gen.py to use cxxheaderparser from sudo apt so we can avoid a pip venv requirement for the build ?

Or alternatively we can pull in the library to our external deps but we shouldn't need a venv to build.

@stellaraccident
Copy link
Contributor

Yes please.

FYI, CI installs it here:

RUN pip install CppHeaderParser

I'd like to have a path to remove that or replace with a system depend. But needed to get started.

@powderluv
Copy link
Contributor Author

file ROCm/clr#134 to track upstream

@jrmadsen
Copy link

jrmadsen commented Feb 2, 2025

For the record, all of that code is related to the old approach for HIP profiling in roctracer. The new rocprofiler-sdk does not rely on it whatsoever. Depending on when this gets adopted, you may not need to concern yourself with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants