Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shortfin_apps.llm] Unit tests and smaller-chunk integration tests #922

Open
renxida opened this issue Feb 6, 2025 · 0 comments
Open

[shortfin_apps.llm] Unit tests and smaller-chunk integration tests #922

renxida opened this issue Feb 6, 2025 · 0 comments
Assignees

Comments

@renxida
Copy link
Contributor

renxida commented Feb 6, 2025

We need more unit tests, and, more importantly, component-integration tests at a level between unit and whole-server integration.

I have been focusing almost exclusively on our integration tests, but this leaves me often wondering what went wrong when the one big integration test fails.

We have been over-relying on the overall integration tests in shortfin_apps. We need defense-in-depth with unit and component tests for, among other things:

  • the batcher
  • generate.py where we manage the lifecycle of a generation request, maintain cache allocations, and store the tokens generated so far for each request
  • config management

A lot of the recent failures in the integration test took WAY too long to debug because we're missing these.

E.g. the trie-cache related incomplete-batch issue that would have been caught if we had component tests that directly sent requests to the batcher (rather than through http) and tested batches of various levels of full-ness.

@renxida renxida self-assigned this Feb 6, 2025
@renxida renxida changed the title [shortfin_apps.llm] Unit / Component Tests [shortfin_apps.llm] Unit tests and smaller-chunk integration tests Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant