Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow to check for conventional commit types #663

Open
anonrig opened this issue Dec 6, 2022 · 2 comments
Open

Update workflow to check for conventional commit types #663

anonrig opened this issue Dec 6, 2022 · 2 comments

Comments

@anonrig
Copy link
Member

anonrig commented Dec 6, 2022

I recommend updating the pull request workflow to check for conventional commit format in the commits, since release changelog requires it.

If there's no objections, I'll be happy to add it.

https://www.conventionalcommits.org/en/v1.0.0/

@aduh95
Copy link
Contributor

aduh95 commented Dec 6, 2022

There's already https://github.com/nodejs/node-core-utils/blob/main/.github/workflows/commitlint.yml, what else do you have in mind?

@anonrig
Copy link
Member Author

anonrig commented Dec 6, 2022

I need we need to also check the title of the pull request for conventional commit format in order to reduce the probability of failures on squashed pull requests with names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants