-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI returns false positive #706
Comments
Is your local ncu up-to-date? I'm getting this: $ git node land 48349
✔ Done loading data for nodejs/node/pull/48349
----------------------------------- PR info ------------------------------------
Title src: introduce V8 fast api to `guessHandleType` (#48349)
Author Yagiz Nizipli <[email protected]> (@anonrig)
Branch anonrig:improve-guessHandleType -> nodejs:main
Labels lib / src, performance, needs-ci, commit-queue-failed, commit-queue-rebase
Commits 2
- src: return uint32 for `guessHandleType`
- src: add V8 fast api to `guessHandleType`
Committers 1
- Yagiz Nizipli <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48349
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
--------------------------------------------------------------------------------
⚠ Commits were pushed since the last approving review:
⚠ - src: return uint32 for `guessHandleType`
⚠ - src: add V8 fast api to `guessHandleType`
ℹ This PR was created on Mon, 05 Jun 2023 16:41:28 GMT
✔ Approvals: 3
✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/48349#pullrequestreview-1465345051
✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/48349#pullrequestreview-1465728186
✔ - Minwoo Jung (@JungMinu): https://github.com/nodejs/node/pull/48349#pullrequestreview-1471073777
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2023-06-14T20:45:52Z: https://ci.nodejs.org/job/node-test-pull-request/52248/
⠋ Querying data for job/node-test-pull-request/52248/ ✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
? This PR is not ready to land, do you want to continue? No
⠋ Querying API for job/node-test-pull-request/52248/ ✔ Aborted `git node land` session in …/node/.ncu |
I think this was a cache issue. While testing my previous PR, the message changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I ran
git node land 48349
which showed thatThis PR should be ready to land
, butcommit-queue
message failed: nodejs/node#48349 (comment)The text was updated successfully, but these errors were encountered: