deps: update ada to 3.1.2 #57208
Closed
deps: update ada to 3.1.2 #57208
+195
−153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
dependencies
|
Review requested:
|
|
|
@richardlau @nodejs/build @nodejs/url any suggestions on how to reproduce this on github.com/ada-url/ada? |
Have you tried the GH Ubuntu 24.04 runner with |
I can't seem to reproduce. |
|
AI 🤖 suggests 💡 an |
Without a reproduction on Ada's CI, it's extremely likely to regress. |
|
@anonrig re. In file included from ../src/node_url_pattern.h:6:
../deps/ada/ada.h:9483:48: error: comparison of integers of different signs: 'const value_type' (aka 'const char') and 'uint32_t' (aka 'unsigned int') [-Werror,-Wsign-compare]
9483 | if (!token->value.empty() && token->value[0] != value) {
| ~~~~~~~~~~~~~~~ ^ ~~~~~
Line 492 in 269c851 and turned into an error by With ada: root@25a538c9f180:/tmp/ada# git status
On branch main
Your branch is up to date with 'origin/main'.
nothing to commit, working tree clean
root@25a538c9f180:/tmp/ada# git rev-parse HEAD
88f992e29de7947c3312f0decd5ba33915e1c881
root@25a538c9f180:/tmp/ada# export CXX=g++-12
root@25a538c9f180:/tmp/ada# export CXXFLAGS="-Werror -Wextra"
root@25a538c9f180:/tmp/ada# cmake -D ADA_TESTING=ON -DBUILD_SHARED_LIBS=OFF -G Ninja -B build
-- The C compiler identification is GNU 11.4.0
-- The CXX compiler identification is GNU 12.3.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/g++-12 - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- No build type selected, default to Release
-- Compiler ID : GNU
-- CMAKE_BUILD_TYPE : Release
-- Assuming GCC-like compiler.
-- CPM: Adding package [email protected] (v1.15.2)
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- CPM: Adding package [email protected] (v3.10.1)
-- Looking for fork
-- Looking for fork - found
-- Looking for wait
-- Looking for wait - found
-- Adding -Og to compile flag
-- The tests are enabled.
-- Found Python3: /usr/bin/python3.10 (found version "3.10.12") found components: Interpreter
-- Python found, we are going to amalgamate.py.
-- Configuring done
-- Generating done
-- Build files have been written to: /tmp/ada/build
root@25a538c9f180:/tmp/ada# cmake --build build -j=4
[11/31] Building CXX object tests/CMakeFiles/wpt_urlpattern_tests.dir/wpt_urlpattern_tests.cpp.o
FAILED: tests/CMakeFiles/wpt_urlpattern_tests.dir/wpt_urlpattern_tests.cpp.o
/usr/bin/g++-12 -DADA_TESTING=1 -DADA_USE_UNSAFE_STD_REGEX_PROVIDER=ON -DSIMDJSON_THREADS_ENABLED=1 -I/tmp/ada/include -I/tmp/ada/build/_deps/simdjson-src/include -isystem /tmp/ada/build/_deps/gtest-src/googletest/include -isystem /tmp/ada/build/_deps/gtest-src/googletest -Werror -Wextra -O3 -DNDEBUG -fPIC -std=c++20 -MD -MT tests/CMakeFiles/wpt_urlpattern_tests.dir/wpt_urlpattern_tests.cpp.o -MF tests/CMakeFiles/wpt_urlpattern_tests.dir/wpt_urlpattern_tests.cpp.o.d -o tests/CMakeFiles/wpt_urlpattern_tests.dir/wpt_urlpattern_tests.cpp.o -c /tmp/ada/tests/wpt_urlpattern_tests.cpp
In file included from /tmp/ada/include/ada.h:35,
from /tmp/ada/tests/wpt_urlpattern_tests.cpp:8:
/tmp/ada/include/ada/url_pattern_helpers-inl.h: In instantiation of 'constexpr bool ada::url_pattern_helpers::constructor_string_parser<regex_provider>::is_non_special_pattern_char(std::size_t, uint32_t) const [with regex_provider = ada::url_pattern_regex::std_regex_provider; std::size_t = long unsigned int; uint32_t = unsigned int]':
/tmp/ada/include/ada/url_pattern_helpers-inl.h:58:10: required from 'constexpr bool ada::url_pattern_helpers::constructor_string_parser<regex_provider>::is_hash_prefix() [with regex_provider = ada::url_pattern_regex::std_regex_provider]'
/tmp/ada/include/ada/url_pattern_helpers-inl.h:864:34: required from 'static tl::expected<ada::url_pattern_init, ada::errors> ada::url_pattern_helpers::constructor_string_parser<regex_provider>::parse(std::string_view) [with regex_provider = ada::url_pattern_regex::std_regex_provider; std::string_view = std::basic_string_view<char>]'
/tmp/ada/include/ada/parser-inl.h:28:78: required from 'tl::expected<ada::url_pattern<regex_provider>, ada::errors> ada::parser::parse_url_pattern_impl(std::variant<std::basic_string_view<char, std::char_traits<char> >, ada::url_pattern_init>, const std::string_view*, const ada::url_pattern_options*) [with regex_provider = ada::url_pattern_regex::std_regex_provider; std::string_view = std::basic_string_view<char>]'
/tmp/ada/include/ada/implementation-inl.h:21:56: required from 'tl::expected<ada::url_pattern<regex_provider>, ada::errors> ada::parse_url_pattern(std::variant<std::basic_string_view<char, std::char_traits<char> >, url_pattern_init>, const std::string_view*, const url_pattern_options*) [with regex_provider = url_pattern_regex::std_regex_provider; std::string_view = std::basic_string_view<char>]'
/tmp/ada/tests/wpt_urlpattern_tests.cpp:21:50: required from here
/tmp/ada/include/ada/url_pattern_helpers-inl.h:105:48: error: comparison of integer expressions of different signedness: 'const __gnu_cxx::__alloc_traits<std::allocator<char>, char>::value_type' {aka 'const char'} and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
105 | if (!token->value.empty() && token->value[0] != value) {
| ~~~~~~~~~~~~~~~~^~~~~~~~
/tmp/ada/tests/wpt_urlpattern_tests.cpp: In function 'std::variant<ada::url_pattern_init, ada::url_pattern_options> parse_init(simdjson::fallback::ondemand::object&)':
/tmp/ada/tests/wpt_urlpattern_tests.cpp:151:19: error: 'value_true' may be used uninitialized [-Werror=maybe-uninitialized]
151 | return ada::url_pattern_options{.ignore_case = value_true};
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/ada/tests/wpt_urlpattern_tests.cpp:149:12: note: 'value_true' was declared here
149 | bool value_true;
| ^~~~~~~~~~
cc1plus: all warnings being treated as errors
[14/31] Building CXX object tests/CMakeFiles/basic_tests.dir/basic_tests.cpp.o
ninja: build stopped: subcommand failed.
root@25a538c9f180:/tmp/ada# |
|
FWIW you can see in the GHA output all of the I did try to build ada with |
|
@richardlau appreciate the help: ada-url/ada#893 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated update of ada to 3.1.2.