-
-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parsing can be extremely slow on macOS #317
Comments
Can you isolate this by creating a test case for mailparser’s own test suite where parsing an email would take so long? From your example it’s hard to understand what’s going on exactly. |
profiling
about half of those values can be traced to
now, we're using parenthetically, i'm hopeful that nodejs/node#32226 might be the source of this headache. it makes as much sense to me as any other explanation, at least... |
the message parsing section of the
emailjs
test suite runs very slowly, even on an M1 Pro; a single test can take 2+ seconds to complete depending on the size of the payload (up to 5.1mb for a text file). this frequently causes test failures in ci, as parsing can take 10+ seconds to complete in github's environment.according to profiling of the message parsing tests, the likely cause is this call (note the percentages):
obviously this is a very esoteric reaction, and i have no idea how or why such a low-level function is hammering / getting hammered by us; the code has been very stable for years & this slowness is not evident on ubuntu or windows. but, likewise, i've observed this slowness for years as well. i'm hopeful maybe there's just some weird one-line performance cliff? but i would have no idea how to start looking for such a thing.
The text was updated successfully, but these errors were encountered: